Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get set all prop types #854

Merged
merged 4 commits into from
Aug 19, 2022
Merged

get set all prop types #854

merged 4 commits into from
Aug 19, 2022

Conversation

blagoev
Copy link
Contributor

@blagoev blagoev commented Aug 19, 2022 •
edited
Loading

We were lacking a read/write test for all types, so we missed the boolean bug with the new ffigen

@cla-bot cla-bot bot added the cla: yes label Aug 19, 2022
@blagoev
Merge branch 'master' into blagoev/get-set-all-prop-types
370f8a2 
# Conflicts:
#	.github/workflows/prepare-release.yml
@blagoev blagoev changed the title Blagoev/get set all prop types get set all prop types Aug 19, 2022
@blagoev blagoev self-assigned this Aug 19, 2022
nielsenko
nielsenko approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consider also adding a test that roundtrip all property types over BaaS.

@blagoev blagoev mentioned this pull request Aug 19, 2022
Merged
@blagoev blagoev merged commit 2f3e709 into master Aug 19, 2022
@blagoev blagoev deleted the blagoev/get-set-all-prop-types branch August 19, 2022 11:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nielsenko nielsenko nielsenko approved these changes

Assignees

@blagoev blagoev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blagoev @nielsenko