New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the correct schema mode for disconnectedSync #999

Merged

nirinchev merged 1 commit into master from ni/disconnected-schema-mode

Oct 31, 2022

Member

nirinchev commented Oct 28, 2022

Noticed that while looking at https://docs.google.com/document/d/17cqTiriugPEJQjvk58t7kwcr9Cdkat5Le7khJOZju5k/edit#. Need to write some tests for it though.


          Set the correct schema mode for disconnectedSync

db80dd7

cla-bot bot added the cla: yes label

github-actions bot assigned nirinchev

blagoev approved these changes

View reviewed changes

nirinchev marked this pull request as ready for review

October 31, 2022 09:02

nielsenko self-requested a review

October 31, 2022 09:03

nielsenko approved these changes

View reviewed changes

Contributor

nielsenko left a comment

Wasn't aware of this flag 👍

coveralls commented Oct 31, 2022 •

edited

Loading

Pull Request Test Coverage Report for Build 3348848830

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.004%) to 89.648%

Totals
Change from base Build 3346340821:	0.004%
Covered Lines:	2650
Relevant Lines:	2956

💛 - Coveralls

1 similar comment

coveralls commented Oct 31, 2022

Pull Request Test Coverage Report for Build 3348848830

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.004%) to 89.648%

Totals
Change from base Build 3346340821:	0.004%
Covered Lines:	2650
Relevant Lines:	2956

💛 - Coveralls

nirinchev merged commit 866497c into master

nirinchev deleted the ni/disconnected-schema-mode branch

October 31, 2022 11:25

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.