Fix credential provider enum #2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| return Equals(obj as User); | ||
| } | ||
| public override bool Equals(object obj) => Equals(obj as User); |
Check warning
Code scanning / CodeQL
Equals should not apply "as"
Pull Request Test Coverage Report for Build 2817236971
💛 - Coveralls |
LaPeste
added a commit
that referenced
this pull request
Aug 22, 2022
author Andrea Catalini <ac_workrelated@tutanota.com> 1660922097 +0200 committer Andrea Catalini <ac_workrelated@tutanota.com> 1660922125 +0200 Sets realm-core to the correct version Fixes testing naming for cleanup in main.yml Test fix Removes unnecessary using Fix Android CI error (#2980) Update to latest Core (#2981) Add Changelog entries from the core upgrade (#2983) Prepare for 10.15.0 (#2984) Co-authored-by: nirinchev <nirinchev@users.noreply.github.com> Prepare for vNext (#2985) Co-authored-by: nirinchev <nirinchev@users.noreply.github.com> Update studio compatibility in changelog Fix credential provider enum (#2988) Prepare for 10.15.1 (#2989) Co-authored-by: nirinchev <nirinchev@users.noreply.github.com> Prepare for vNext (#2990) Co-authored-by: nirinchev <nirinchev@users.noreply.github.com> Fixes an issue after merging main Renames strategies as agreed on all SDKs More of the same -> better docs for FLX-S unsupported modes - 2 Facepalm deletion Corrects a few typos in comments Addresses PR feedback Adds a test to ensure obsolete strategy still works More PR feedback Removes linter errors Removes build warnings Removes more style warnings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Core changed the enum values, resulting in the wrong provider being used when logging in.
Fixes #2987
TODO