-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow primitive fields to have @Required annotation #4927
Comments
I think so ... do we throw in current release? |
I don't see the purpose of it - it's implicitly |
What @Zhuinden said. What would the use case be for wanting this? That said, allowing it is probably not harmful so 🤷♂️ |
I heard the following case. At first, they defined a field After that, build failure happened with bunch of Dagger errors. I didn't have the reason why we didn't accept for primitive fields to have What do you think? |
I would say we accept pull requests :) TBH I don't think it is something we should prioritize. |
I would love to contribute. Is this still valid? |
I think now that both |
I got a request from a user.
I think that just ignoring
@Required
annotation is fine if the field has primitive type.What do you think? @realm/java
The text was updated successfully, but these errors were encountered: