Store unstripped jni so #1326
Merged
Store unstripped jni so #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gold linker has a bug when creating map file, see https://answers.madewithmarmalade.com/questions/32748/android-extension-build-fails-77-ndk-r10e.html Unstripped so is not really convenient, but is useful write now. Will write a wiki on how to parse the symbols. |
|
|
||
| // Store the unstripped version | ||
| from "${projectDir}/src/librealm-jni-${target.name}.so" | ||
| into "${projectDir}/../realm/src/main/jniLibs-unstripped/${target.jniFolder}" |
There was a problem hiding this comment.
Wouldn't it be better to store this in the build directory somewhere? Probably under /build/outputs/jniLibs-unstripped?
There was a problem hiding this comment.
OK, change it right now.
|
Apart from comments 👍 |
beeender
force-pushed
the
mc-cp-non-stripped-so
branch
from
f3f526b
to
49c1b30
Compare
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
beeender
force-pushed
the
mc-cp-non-stripped-so
branch
from
49c1b30
to
5a01ff6
Compare
|
retest this please |
beeender
force-pushed
the
mc-cp-non-stripped-so
branch
from
5a01ff6
to
f175e20
Compare
|
retest this please |
|
I think I would have preferred two tasks instead of one, but this is fine 👍 |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.