Merge release into master #1828
Conversation
Close #1775 A String or Binary pointer retrieved from Realm is invalidated when set_string called.
Buffer overwritten caused PK migration failure
Conflicts: changelog.txt version.txt
|
@mc I did the merge again from scrap and fixed the problems I met on the way. Ready for review @realm/java |
| jcenter() | ||
| } | ||
| dependencies { | ||
| //classpath 'org.jfrog.buildinfo:build-info-extractor-gradle:3.1.1' |
| @@ -395,8 +399,7 @@ bintray { | |||
| } | |||
|
|
|||
| release { | |||
| dependsOn distributionPackage | |||
| push = true | |||
| push = false | |||
There was a problem hiding this comment.
How does this work if executed on the build server? Then the change would only be locally there?
There was a problem hiding this comment.
We're not ready for the build server yet. In a few iterations this will change.
|
Duplicating the publication info across 5 files looks extremely difficult to maintain, but if it is a temporary solution I guess it is ok. |
| key = project.hasProperty('bintrayKey') ? bintrayKey : 'noKey' | ||
|
|
||
| dryRun = false | ||
| publish = false |
There was a problem hiding this comment.
Do we want to manually publish all of these?
There was a problem hiding this comment.
For the moment, yes. When automation kick in, not anymore.
| @@ -1 +1,2 @@ | |||
| 0.86.0-SNAPSHOT | |||
| 0.85.2-SNAPSHOT | |||
There was a problem hiding this comment.
Shouldn't this be 0.86.0-SNAPSHOT ?
There was a problem hiding this comment.
No, the release plugin now takes care of the version file. We don't need to touch it anymore :)
There was a problem hiding this comment.
If the relase plugin takes care of ther version, can we fill it up the blank? I think 0.85.2-SNAPSHOT is little confusing.
There was a problem hiding this comment.
I'm not sure what you mean @dalinaum
|
👍 |
No description provided.