Add sample app demonstrating offline mode #1960

cmelchior · 2015-12-17T16:03:36Z

Sample app demonstrating usage of Realm in a app that should work offline.

It uses the New York Times API to show a list of news items. Each item will be marked read after being visible for 2 seconds.

Simpel MVP architecture
Separation between Model/Repository
Uses RxJava/Retrofit/Jackson

…worded Javadoc.

Conflicts: realm/gradle/wrapper/gradle-wrapper.properties realm/realm-library/src/main/java/io/realm/BaseRealm.java realm/realm-library/src/main/java/io/realm/RealmObject.java realm/realm-library/src/main/java/io/realm/RealmResults.java

Conflicts: realm/gradle/wrapper/gradle-wrapper.properties realm/realm-library/src/main/java/io/realm/BaseRealm.java

Conflicts: realm/realm-library/build.gradle

…variants

Conflicts: changelog.txt examples/gradle/wrapper/gradle-wrapper.properties realm/realm-library/src/main/java/io/realm/RealmQuery.java

Conflicts: examples/settings.gradle realm/realm-jni/src/io_realm_internal_TableQuery.h realm/realm-library/src/androidTest/java/io/realm/RxJavaTests.java realm/realm-library/src/main/java/io/realm/Realm.java realm/realm-library/src/main/java/io/realm/RealmObject.java realm/realm-library/src/main/java/io/realm/rx/RealmObservableFactory.java realm/realm-library/src/main/java/io/realm/rx/RxObservableFactory.java

cmelchior · 2016-01-19T10:19:45Z

@beeender https://www.youtube.com/watch?v=R0FXPqYpt0g

cmelchior · 2016-02-16T10:40:02Z

Looked like this PR has gotten a bit stale. Everything should be ready for review @realm/java

zaki50 · 2016-02-16T11:06:11Z

examples/newsreaderExample/src/main/res/layout/activity_main.xml

+
+            <Spinner
+                android:id="@+id/spinner"
+


cmelchior · 2016-02-16T11:20:28Z

Imbarrassing. I can reproduce the crash:

  NewsReaderApplication  E  java.lang.IllegalStateException: Realm access from incorrect thread. Realm objects can only 
                            be accessed on the thread they were created.
                         E  java.lang.IllegalStateException: Exception thrown on Scheduler.Worker thread. Add `onError` 
                            handling.
         AndroidRuntime  E  FATAL EXCEPTION: RxComputationThreadPool-3
                         E  Process: io.realm.examples.newsreader, PID: 7304
                         E  java.lang.IllegalStateException: Exception thrown on Scheduler.Worker thread. Add `onError` 
                            handling.
                         E      at rx.internal.schedulers.ScheduledAction.run(ScheduledAction.java:60)
                         E      at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:422)
                         E      at java.util.concurrent.FutureTask.run(FutureTask.java:237)
                         E      at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(Sched
                            uledThreadPoolExecutor.java:152)
                         E      at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThr
                            eadPoolExecutor.java:265)
                         E      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
                         E      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
                         E      at java.lang.Thread.run(Thread.java:818)
                         E  Caused by: rx.exceptions.OnErrorNotImplementedException: Realm access from incorrect thread.
                             Realm objects can only be accessed on the thread they were created.
                         E      at rx.Observable$27.onError(Observable.java:7923)
                         E      at rx.observers.SafeSubscriber._onError(SafeSubscriber.java:159)
                         E      at rx.observers.SafeSubscriber.onError(SafeSubscriber.java:120)
                         E      at rx.observers.SafeSubscriber.onNext(SafeSubscriber.java:146)
                         E      at rx.internal.operators.OnSubscribeTimerOnce$1.call(OnSubscribeTimerOnce.java:49)
                         E      at rx.internal.schedulers.ScheduledAction.run(ScheduledAction.java:55)
                         E      ... 7 more
                         E  Caused by: java.lang.IllegalStateException: Realm access from incorrect thread. Realm object
                            s can only be accessed on the thread they were created.
                         E      at io.realm.BaseRealm.checkIfValid(BaseRealm.java:377)
                         E      at io.realm.Realm.executeTransaction(Realm.java:1065)
                         E      at io.realm.examples.newsreader.model.Repository.updateStoryReadState(Repository.java:10
                            9)
                         E      at io.realm.examples.newsreader.model.Model.markAsRead(Model.java:103)
                         E      at io.realm.examples.newsreader.ui.details.DetailsPresenter$2.call(DetailsPresenter.java
                            :68)
                         E      at io.realm.examples.newsreader.ui.details.DetailsPresenter$2.call(DetailsPresenter.java
                            :65)
                         E      at rx.Observable$27.onNext(Observable.java:7928)
                         E      at rx.observers.SafeSubscriber.onNext(SafeSubscriber.java:139)
                         E      ... 9 more

zaki50 · 2016-02-16T11:31:48Z

crash after opening DetailsActivity

java.lang.IllegalStateException: Realm access from incorrect thread. Realm objects can only be accessed on the thread they were created.

02-16 20:06:37.527 24294-27771/io.realm.examples.newsreader E/NewsReaderApplication: java.lang.IllegalStateException: Realm access from incorrect thread. Realm objects can only be accessed on the thread they were created.
02-16 20:06:37.528 24294-27771/io.realm.examples.newsreader E/NewsReaderApplication: java.lang.IllegalStateException: Exception thrown on Scheduler.Worker thread. Add `onError` handling.

                                                                                     --------- beginning of crash
02-16 20:06:37.529 24294-27771/io.realm.examples.newsreader E/AndroidRuntime: FATAL EXCEPTION: RxComputationThreadPool-3
                                                                              Process: io.realm.examples.newsreader, PID: 24294
                                                                              java.lang.IllegalStateException: Exception thrown on Scheduler.Worker thread. Add `onError` handling.
                                                                                  at rx.internal.schedulers.ScheduledAction.run(ScheduledAction.java:60)
                                                                                  at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:423)
                                                                                  at java.util.concurrent.FutureTask.run(FutureTask.java:237)
                                                                                  at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:269)
                                                                                  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
                                                                                  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
                                                                                  at java.lang.Thread.run(Thread.java:818)
                                                                               Caused by: rx.exceptions.OnErrorNotImplementedException: Realm access from incorrect thread. Realm objects can only be accessed on the thread they were created.
                                                                                  at rx.Observable$27.onError(Observable.java:7923)
                                                                                  at rx.observers.SafeSubscriber._onError(SafeSubscriber.java:159)
                                                                                  at rx.observers.SafeSubscriber.onError(SafeSubscriber.java:120)
                                                                                  at rx.observers.SafeSubscriber.onNext(SafeSubscriber.java:146)
                                                                                  at rx.internal.operators.OnSubscribeTimerOnce$1.call(OnSubscribeTimerOnce.java:49)
                                                                                  at rx.internal.schedulers.ScheduledAction.run(ScheduledAction.java:55)
                                                                                  at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:423) 
                                                                                  at java.util.concurrent.FutureTask.run(FutureTask.java:237) 
                                                                                  at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:269) 
                                                                                  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113) 
                                                                                  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588) 
                                                                                  at java.lang.Thread.run(Thread.java:818) 
                                                                               Caused by: java.lang.IllegalStateException: Realm access from incorrect thread. Realm objects can only be accessed on the thread they were created.
                                                                                  at io.realm.BaseRealm.checkIfValid(BaseRealm.java:377)
                                                                                  at io.realm.Realm.executeTransaction(Realm.java:1065)
                                                                                  at io.realm.examples.newsreader.model.Repository.updateStoryReadState(Repository.java:109)
                                                                                  at io.realm.examples.newsreader.model.Model.markAsRead(Model.java:103)
                                                                                  at io.realm.examples.newsreader.ui.details.DetailsPresenter$2.call(DetailsPresenter.java:68)
                                                                                  at io.realm.examples.newsreader.ui.details.DetailsPresenter$2.call(DetailsPresenter.java:65)
                                                                                  at rx.Observable$27.onNext(Observable.java:7928)
                                                                                  at rx.observers.SafeSubscriber.onNext(SafeSubscriber.java:139)
                                                                                  at rx.internal.operators.OnSubscribeTimerOnce$1.call(OnSubscribeTimerOnce.java:49) 
                                                                                  at rx.internal.schedulers.ScheduledAction.run(ScheduledAction.java:55) 
                                                                                  at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:423) 
                                                                                  at java.util.concurrent.FutureTask.run(FutureTask.java:237) 
                                                                                  at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:269) 
                                                                                  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113) 
                                                                                  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588) 
                                                                                  at java.lang.Thread.run(Thread.java:818) 
02-16 20:06:38.866 24294-24294/io.realm.examples.newsreader D/NYTimesDataLoader: Success - Data received: home
02-16 20:09:56.614 24294-27771/io.realm.examples.newsreader I/Process: Sending signal. PID: 24294 SIG: 9

zaki50 · 2016-02-16T11:33:55Z

examples/newsreaderExample/src/main/res/layout/content_main.xml

+    android:layout_height="match_parent"
+    android:paddingBottom="0dp"
+    android:paddingLeft="@dimen/activity_horizontal_margin"
+    android:paddingRight="@dimen/activity_horizontal_margin"


It's better to remove these paddings.

dalinaum · 2016-02-16T12:58:25Z

@zaki50 said that it encountered the following error.

Realm access from incorrect thread. Realm objects can only be accessed on the thread they were created.

Repository() is initialized on @UiThread https://github.com/realm/realm-java/pull/1960/files#diff-0df357d98f97bc637ce62b4a514ba538R56 and updateStoryReadState() is invoked on @UiThread https://github.com/realm/realm-java/pull/1960/files#diff-0df357d98f97bc637ce62b4a514ba538R107 too.

Does @UiThread annotation guarantee that methods with this annotation invoke on UI Thread?

zaki50 · 2016-02-16T13:18:10Z

...ples/newsreaderExample/src/main/java/io/realm/examples/newsreader/NewsReaderApplication.java

+    }
+
+    /**
+     * Initialize Timer logging


Timer -> Timber

zaki50 · 2016-02-16T13:25:14Z

@dalinaum @UiThread annotation is only a marker for lint. No guarantee for execution of UI thread.

see http://tools.android.com/tech-docs/support-annotations

cmelchior · 2016-02-16T15:12:46Z

Ups, found the crash. It was a Scheduler issue, not sure how I missed that 😕 Also moved away from deprecated transaction API's

@realm/java

dalinaum · 2016-02-19T07:29:23Z

👍

cmelchior · 2016-02-19T07:33:29Z

@dalinaum 🍰

Add sample app demonstrating offline mode

Drjacky · 2017-11-26T07:24:35Z

@cmelchior Thank you for the sample app, but the API doesn't work!
api.nytimes.com

{"request_path":"/","message":"API not found with these values","request_host":["api.nytimes.com"]}

D/NYTimesDataLoader: Failure: Data not loaded: health - java.net.UnknownHostException: Unable to resolve host "api.nytimes.com": No address associated with hostname

beeender · 2017-11-28T02:41:17Z

@Drjacky It should be your network issue. It is working here (just tested with the apk)

➜  ✗ ping api.nytimes.com 
PING api.nytimes.com (34.234.50.162) 56(84) bytes of data.

Drjacky · 2017-11-28T05:46:23Z

@beeender Yea, you're right. But it's weird that it doesn't work either via VPN!

Pinging infodev-kong-v3-prd-444147425.us-east-1.elb.amazonaws.com [54.172.233.25
5] with 32 bytes of data:
Request timed out.
Request timed out.
Request timed out.
Request timed out.
Ping statistics for 54.172.233.255:
Packets: Sent = 4, Received = 0, Lost = 4 (100% loss),

Thanks anyway to informed me.

cmelchior added 30 commits October 30, 2015 13:08

Added RxObservableFactory for RxJava 1.0.*

afc3115

RxJava example + Initial exposure of Observables for Realm objects.

1068e5f

Added RxJava examples + POC implementation of Observable support.

b0a4c69

More documentation + examples.

a4d714d

Merge branch 'master' into feature-rxjava

502c02a

Create RxJava factory interface, and add it to RealmConfiguration. Re…

35db4b9

…worded Javadoc.

Fix bug in detect RxJava logic.

c4107b4

PR feedback

0e423d0

Revert maven repo location

67879fa

More examples.

9c95981

Merge branch 'master' into feature-rxjava

096ae91

Conflicts: realm/gradle/wrapper/gradle-wrapper.properties realm/realm-library/src/main/java/io/realm/BaseRealm.java realm/realm-library/src/main/java/io/realm/RealmObject.java realm/realm-library/src/main/java/io/realm/RealmResults.java

Make Rx factory public.

48ac92c

Fixed unit tests

3817169

Cleanup

dcd7ff1

Remove generic parameter from RealmObject

5a45ea8

Remove generic parameter from BaseRealm

3123441

Back to generified RealmObject

1727dfa

Merge branch 'master' into feature-rxjava

b72fe80

Move example to own branch

c1a0bad

Merge branch 'master' into feature-rxjava

29aef5e

Conflicts: realm/gradle/wrapper/gradle-wrapper.properties realm/realm-library/src/main/java/io/realm/BaseRealm.java

Merge branch 'master' into feature-rxjava

adaeeb2

Conflicts: realm/realm-library/build.gradle

Update API, Javadoc and unit tests.

3630420

Javadoc cleanup

e02c524

Add unsubscribe test

633cd5d

Added Realm parameter to factory, added explicit methods for dynamic …

82e17b6

…variants

Merge branch 'master' into feature-rxjava

237a937

Conflicts: changelog.txt examples/gradle/wrapper/gradle-wrapper.properties realm/realm-library/src/main/java/io/realm/RealmQuery.java

Splitting RealmQuery + advanced support into its own branch

eb4f44b

Cleanup

ebe632b

Add sample app demonstrating offline mode

9186e49

cmelchior added 2 commits January 25, 2016 15:06

Cleanup + add UIThread annotations

f711fc1

Merge branch 'master' into cm/offline-newsreader

3f347d9

cmelchior self-assigned this Jan 26, 2016

bmunkholm added the T-Doc label Feb 2, 2016

cmelchior added T-Doc and removed T-Doc labels Feb 10, 2016

Merge branch 'master' into cm/offline-newsreader

9711029

zaki50 reviewed Feb 16, 2016
View reviewed changes

examples/newsreaderExample/src/main/res/layout/activity_main.xml

<Spinner

android:id="@+id/spinner"

Copy link

Contributor

zaki50 Feb 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line

zaki50 reviewed Feb 16, 2016
View reviewed changes

cmelchior added 2 commits February 16, 2016 16:07

New async transaction API used, Fixed scheduler bug. Cleanup

f7b895c

Padding

a3b727c

cmelchior added a commit that referenced this pull request Feb 19, 2016

Merge pull request #1960 from realm/cm/offline-newsreader

99a9ca4

Add sample app demonstrating offline mode

cmelchior merged commit 99a9ca4 into master Feb 19, 2016

cmelchior deleted the cm/offline-newsreader branch February 19, 2016 07:33

cmelchior removed the S:Review label Feb 19, 2016

github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add sample app demonstrating offline mode #1960

Add sample app demonstrating offline mode #1960

cmelchior commented Dec 17, 2015

cmelchior commented Jan 19, 2016

cmelchior commented Feb 16, 2016

zaki50 Feb 16, 2016

cmelchior commented Feb 16, 2016

zaki50 commented Feb 16, 2016

zaki50 Feb 16, 2016

dalinaum commented Feb 16, 2016

zaki50 Feb 16, 2016

zaki50 commented Feb 16, 2016

cmelchior commented Feb 16, 2016

dalinaum commented Feb 19, 2016

cmelchior commented Feb 19, 2016

Drjacky commented Nov 26, 2017

beeender commented Nov 28, 2017

Drjacky commented Nov 28, 2017

Add sample app demonstrating offline mode #1960

Add sample app demonstrating offline mode #1960

Conversation

cmelchior commented Dec 17, 2015

cmelchior commented Jan 19, 2016

cmelchior commented Feb 16, 2016

zaki50 Feb 16, 2016

Choose a reason for hiding this comment

cmelchior commented Feb 16, 2016

zaki50 commented Feb 16, 2016

zaki50 Feb 16, 2016

Choose a reason for hiding this comment

dalinaum commented Feb 16, 2016

zaki50 Feb 16, 2016

Choose a reason for hiding this comment

zaki50 commented Feb 16, 2016

cmelchior commented Feb 16, 2016

dalinaum commented Feb 19, 2016

cmelchior commented Feb 19, 2016

Drjacky commented Nov 26, 2017

beeender commented Nov 28, 2017

Drjacky commented Nov 28, 2017