Adding javadoc to explain that items will be continually be emitted u… #2201
Conversation
| * when subscribed to. Items will continually be emitted as the Realm is updated - | ||
| * {@code onComplete} will never be called. | ||
| * | ||
| * If you would like the {@code asObservable()} to stop emitting items you can instruct Rx to |
There was a problem hiding this comment.
Is it RxJava or just Rx ?
There was a problem hiding this comment.
I should make it RxJava. Will fix.
|
I like it, and great with the example as well. We need to update the other |
|
Ahh, will do. I'll update the other classes. |
|
@cmelchior Updated the RealmObject and RealmResults. Let me know about the code formatting |
|
Looks like I was wrong, It seems that using both |
| * | ||
| * <pre> | ||
| * {@code | ||
| * realm.where(Foo.class).findAllAsync().asObservable() |
There was a problem hiding this comment.
I would adjust the example to fit the context. In this one, we are observing on a Realm:
realm.asObservable().first()
|
@cmelchior All requested changes have been made. :) |
|
Looks good to me. 👍 once squashed. |
|
👍 |
…nless other wise instructed with the first() operator. Closes realm#2135 Changing Rx -> RxJava for clarity. Adding asObservable comments to RealmObject and RealmResults. Fixing BaseRealm example as we are observing the Realm, not the results. Fixing lambda example. Using Async example for RealmResults.
donnfelker
force-pushed
the
df/observable-javadoc
branch
from
99f0647
to
15042c5
Compare
|
@cmelchior Squashed. |
|
Hmm, looks like a regression on our part somewhere: io.realm.RealmSchemaTests.remove_classWithReferencesThrows (from io.realm.DynamicRealmObjectTests) |
|
Do you need me to do anything to help push this along? |
|
No, this PR shouldn't cause any build failure. I'll look into it. |
Adding javadoc to explain that items will be continually be emitted u…
…nless other wise instructed with the first() operator.
Closes #2135