Realm Observables now holds a Realm instance reference #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -311,7 +336,7 @@ public void call(DynamicRealm rxRealm) { | |||
| @UiThreadTest | |||
| public void unsubscribe() { | |||
There was a problem hiding this comment.
change name to unsubscribe_onWrongThread ?
|
Besides some minor comments, 👍 |
cmelchior
force-pushed
the
cm/rxjava-close-bug
branch
from
0663ac3
to
7ea8745
Compare
|
👍 |
| return Observable.create(new Observable.OnSubscribe<Realm>() { | ||
| @Override | ||
| public void call(final Subscriber<? super Realm> subscriber) { | ||
| // Get instance to make sure that the Realm is open for as long as the | ||
| // Observable is subscribed to. |
|
just minor comments issues, but they happen in a bunch of places. Otherwise this looks good to me 👍 |
| } | ||
| })); | ||
|
|
||
| // Immediately call onNext with the current value, as due to Realms auto-update, it will be the latest |
cmelchior
force-pushed
the
cm/rxjava-close-bug
branch
from
7ea8745
to
389828d
Compare
cmelchior
added a commit
that referenced
this pull request
Mar 7, 2016
Realm Observables now holds a Realm instance reference
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2357
Due to how RxJava executes the chain of Observables, currently it isn't possible to use
doOnUnsubscribe()to close Realm instances as the side-effect is triggered before the Observable is truly unsubscribed to (crashing our 'removeChangeListeners() method).This PR changes the current implementation so each Observable also holds onto a Realm instance prevent the Realm from being fully closed until the Observable is unsubscribed to. This means we can now guarantee that the Realm is alive for as long as the Observable is subscribed to. The only downside is that you risk leaking Realm instances if you forget to unsubscribe, but that would be a memory leak in any case.
@realm/java
/cc @lucamtudor