Upgrading to Realm Core 0.97.0

[kneth]

@realm/java

[beeender]

Not sure if https://github.com/realm/realm-object-store/pull/52/files#r55271290 this change has impact on us as well. in completedAsyncQueriesUpdate

[kneth]

@beeender The error in the failing test seems to indicate it :-)

[cmelchior]

Should this PR also modify our deleteRealm method? since (all?) the auxillary files are now inlined?

[kneth]

@cmelchior We can remove the aux. files from the list but then removing old database will leave these files untouched. Adding a note to the change log that you must manually remove aux. files is an option.

[cmelchior]

I guess leaving it in for now isn't a big issue.

[nhachicha]

Why?

[kneth]

We get a LogicError exception when you try to open the Realm with explicit transaction if it is already opened with implicit transaction. I haven't talked with the core team so I don't know if they are aware of it.

[nhachicha]

LGTM besides small comments

[beeender]

The TableView's version could be std::numeric_limits<uint64_t>::max() for the default of the source LinkView gets deleted. See realm/realm-core#1510 . After the max uint64_t convert to jlong, it give -1 which is accidentally the same with our RealmResults.TABLE_VIEW_VERSION_NONE. I checked the code, and it seems to be no problem with current implementation. However, @nhachicha would you please help to check again? This can be hard to debug if there is a problem in the future.

[cmelchior]

I think that std::numeric_limits<uint64_t>::max() have always been the value used internally by Core, but now it just got more visible.

[cmelchior]

👍

[nhachicha]

👍

[beeender]

👍

[stk1m1]

👍