Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseRealm should be package protected #2673

Merged
merged 2 commits into from Apr 27, 2016
Merged

BaseRealm should be package protected #2673

merged 2 commits into from Apr 27, 2016

Conversation

beeender
Copy link
Contributor

No description provided.

@nhachicha nhachicha mentioned this pull request Apr 26, 2016
Closed
11 tasks
@beeender beeender added this to the 0.90 milestone Apr 26, 2016
@cmelchior
Copy link
Contributor

cmelchior commented Apr 26, 2016 •
edited

If this is enough 👍 , but you should probably get @nhachicha to verify.
EDIT: Remember changelog update

@nhachicha
Copy link
Collaborator

LGTM, when I refactored the ProxyState to be returned inside the generated Proxy class, I didn't noticed that we end up with DynamicRealmObject and the generated classes being in the same package io.realm so having BaseRealm as package private makes sense now 👍

@beeender beeender force-pushed the mc/api-review/internal-baserealm branch from e9b70ca to 3ae3dbb Compare April 26, 2016 11:55
@beeender
Copy link
Contributor Author

CI: retest this please

@beeender
Copy link
Contributor Author

retest this please

@beeender
Copy link
Contributor Author

CI passed, but cannot send result back. See https://ci.realm.io/job/android-pr/239/

@beeender beeender merged commit bc841d4 into master Apr 27, 2016
@beeender beeender deleted the mc/api-review/internal-baserealm branch April 27, 2016 02:01
@beeender beeender removed the S:Review label Apr 27, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.90
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@beeender @cmelchior @nhachicha