Make all methods on RealmObject and all classes in public API final #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaki50
changed the title
11 tasks
zaki50
force-pushed
the
my/api-review/final
branch
2 times, most recently
from
9df5a84
to
cb6cf29
Compare
zaki50
force-pushed
the
my/api-review/final
branch
from
cb6cf29
to
ab163d9
Compare
|
👍 |
1 similar comment
|
👍 |
zaki50
added a commit
that referenced
this pull request
Apr 26, 2016
cmelchior
pushed a commit
that referenced
this pull request
Apr 26, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1594. Merge all together in one release.
@realm/java
Final commit note:
Title: Make all methods on RealmObject and all classes in public API final
We should mark all methods that should not be overridden final.
We should mark all classes that should not be inherited final.