Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1594 RealmChangeListener should provide the changes object/realm/collection as well #2705

Merged
merged 5 commits into from Apr 29, 2016
Merged

#1594 RealmChangeListener should provide the changes object/realm/collection as well #2705

merged 5 commits into from Apr 29, 2016

Conversation

nhachicha
Copy link
Collaborator

@nhachicha
Copy link
Collaborator Author

@realm/java

@nhachicha nhachicha self-assigned this Apr 29, 2016
cmelchior
cmelchior reviewed Apr 29, 2016
View reviewed changes
realm/realm-library/src/androidTest/java/io/realm/RealmChangeListenerTests.java
@Test
@RunTestInLooperThread
public void returnedRealmResultsOfModelIsNotNull() {
RealmResults<AllTypesRealmModel> alltypes = looperThread.realm.where(AllTypesRealmModel.class).findAll();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps refactor looperThread.realm into its own variable:

Realm realm = looperThread.realm;
...

It makes the tests easier to read.

@cmelchior
Copy link
Contributor

Missing a changelog update, but apart from that and some minor comments 👍

kneth
kneth reviewed Apr 29, 2016
View reviewed changes
CHANGELOG.md
@@ -2,6 +2,7 @@

### Breaking changes

* RealmChangeListener provide the changed object/realm/collection as well (#1594)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add . at the end.

@kneth
Copy link
Member

kneth commented Apr 29, 2016

👍 with just minor comment.

@stk1m1
Copy link
Contributor

stk1m1 commented Apr 29, 2016

👍 Good work!

@cmelchior
Copy link
Contributor

cmelchior commented Apr 29, 2016 •
edited

I like onChange(T element) better than onChange(T object). Looking at alternatives was RxJava call(T t) and Java Observable onUpdate(Object arg). So there doesn't seem to be any consensus anyway. 👍 :shipit:

@nhachicha nhachicha merged commit c0a13d7 into master Apr 29, 2016
@nhachicha nhachicha deleted the nh/RealmChangeWithArgument branch April 29, 2016 23:08
@nhachicha nhachicha mentioned this pull request May 3, 2016
Closed
11 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@nhachicha nhachicha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nhachicha @cmelchior @kneth @stk1m1