Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadoc for findFirstAsync #4367

Merged
merged 2 commits into from
Mar 24, 2017
Merged

Javadoc for findFirstAsync #4367

merged 2 commits into from
Mar 24, 2017

Conversation

beeender
Copy link
Contributor

Fix #4360

Copy link
Contributor

@cmelchior cmelchior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion to improve wording

* Similar to {@link #findFirst()} but runs asynchronously on a worker thread. An listener should be registered to
* the returned {@link RealmObject} to get the notification when query completes. The registered listener will also
* be triggered if there are changes made to the queried {@link RealmObject}. If the {@link RealmObject} is deleted,
* the listener will be called the last time and the query will not be re-executed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

called one last time and then stop. The query will not be re-run.

@cmelchior cmelchior added this to the 3.1 milestone Mar 23, 2017
Copy link
Contributor

@zaki50 zaki50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@beeender beeender merged commit d79de2d into master Mar 24, 2017
@beeender beeender removed the S:Review label Mar 24, 2017
@beeender beeender deleted the mc/doc-findfirstasync branch March 24, 2017 10:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants