Skip to content

Commit

Permalink
Updating pr-realm-js workflow - cleaning up parentheses
Browse files Browse the repository at this point in the history
  • Loading branch information
kraenhansen committed Feb 19, 2024
1 parent 9bf968b commit 0a119eb
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions .github/workflows/pr-realm-js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ jobs:
# On linux, electron requires a connected display. We fake this by giving it a headless environment using xvfb
# Relevant issue: https://github.com/juliangruber/browser-run/issues/147
- name: Linux Environment setup
if: ${{ (matrix.variant.runner == 'ubuntu-latest') }}
if: ${{ matrix.variant.runner == 'ubuntu-latest' }}
run: sudo apt-get install ccache ninja-build

- name: Setup Java
Expand Down Expand Up @@ -184,13 +184,13 @@ jobs:
# build the c++ library for standard targets
- name: Build node
if: ${{ (matrix.variant.os != 'ios') && (matrix.variant.os != 'android') }}
if: ${{ matrix.variant.os != 'ios' && matrix.variant.os != 'android' }}
run: npm run build:node:prebuild:${{matrix.variant.arch}} --workspace realm

# build the c++ library for IOS
# the Info.plist needs to be regenerated with all libraries in place
- name: Build iOS
if: ${{ (matrix.variant.os == 'ios') }}
if: ${{ matrix.variant.os == 'ios' }}
run: |
npm run build:ios --workspace realm
rm -vf ${{ matrix.variant.artifact-path }}/Info.plist
Expand All @@ -199,7 +199,7 @@ jobs:

# build the c++ library for Android
- name: Build Android
if: ${{ (matrix.variant.os == 'android') }}
if: ${{ matrix.variant.os == 'android' }}
run: npm run build:android --workspace realm -- --arch=${{matrix.variant.arch}}

# Due to a limitation in upload-artifact a redundant file is needed to force
Expand Down Expand Up @@ -338,12 +338,12 @@ jobs:
version: 1.14.3

- name: Install IOS tools
if: ${{ (matrix.variant.os == 'ios') }}
if: ${{ matrix.variant.os == 'ios' }}
run: |
npm install -g ios-deploy
- name: Set xvfb wrapper for Linux / electron tests
if: ${{ (matrix.variant.os == 'linux') && (matrix.variant.environment == 'electron' )}}
if: ${{ matrix.variant.os == 'linux' && matrix.variant.environment == 'electron' }}
run: |
sudo apt-get install xvfb
echo "wrapper=xvfb-run" >> $GITHUB_ENV
Expand Down Expand Up @@ -386,22 +386,22 @@ jobs:
run: echo "context=syncLogLevel=warn,longTimeout=${{ env.LONG_TIMEOUT }},realmBaseUrl=${{ steps.baas.outputs.baas-url }}" >> $GITHUB_OUTPUT

- name: Run ${{matrix.variant.target}} (${{ matrix.variant.os}} / ${{ matrix.variant.environment }})
if: ${{ (matrix.variant.os != 'android') && (matrix.variant.os != 'ios') }}
if: ${{ matrix.variant.os != 'android' && matrix.variant.os != 'ios' }}
env:
MOCHA_REMOTE_CONTEXT: ${{ steps.mocha-env.outputs.context }}
# The non react native environments should not take so long
timeout-minutes: 60
run: ${{ env.wrapper }} npm run ${{ matrix.variant.target}} --prefix integration-tests/environments/${{ matrix.variant.environment }}

- name: Run ${{matrix.variant.target}} (${{ matrix.variant.os}} / ${{ matrix.variant.environment }})
if: ${{ (matrix.variant.os == 'ios') }}
if: ${{ matrix.variant.os == 'ios' }}
env:
MOCHA_REMOTE_CONTEXT: ${{ steps.mocha-env.outputs.context }}
timeout-minutes: 75
run: npm run ${{ matrix.variant.target}} --prefix integration-tests/environments/${{ matrix.variant.environment }}

- name: Setup Java Gradle cache for android test app
if: ${{ (matrix.variant.os == 'android') }}
if: ${{ matrix.variant.os == 'android' }}
uses: actions/cache@v3
with:
path: |
Expand All @@ -412,7 +412,7 @@ jobs:
${{ runner.os }}-gradle-
- name: Setup Android Emulator cache
if: ${{ (matrix.variant.os == 'android') }}
if: ${{ matrix.variant.os == 'android' }}
uses: actions/cache@v3
id: avd-cache
with:
Expand All @@ -422,13 +422,13 @@ jobs:
key: avd-29

- uses: actions/setup-java@v3
if: ${{ (matrix.variant.os == 'android') }}
if: ${{ matrix.variant.os == 'android' }}
with:
distribution: 'zulu' # See 'Supported distributions' for available options
java-version: '17'

- name: Run ${{matrix.variant.target}} (${{ matrix.variant.os}} / ${{ matrix.variant.environment }})
if: ${{ (matrix.variant.os == 'android') }}
if: ${{ matrix.variant.os == 'android' }}
env:
MOCHA_REMOTE_CONTEXT: ${{ steps.mocha-env.outputs.context }}
timeout-minutes: 75
Expand Down

0 comments on commit 0a119eb

Please sign in to comment.