Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Syntax #4

Closed
bleonard opened this issue Sep 3, 2015 · 4 comments
Closed

Query Syntax #4

bleonard opened this issue Sep 3, 2015 · 4 comments

Comments

@bleonard
Copy link

bleonard commented Sep 3, 2015

I might be a good idea to take a in an object (key value pairs) for querying instead of having people put together a string.

It would work for single parameter queries. If there are multiple it would assume AND -- these seems to be the most common case.

Notes;

  • allow empty query or null to be no filters
  • auto escape strings and such
  • ideally on a string or int column, i should be able to give an array - this would translate to an IN query if it was MySQL. ActiveRecord does this and I think it's super useful.
@bleonard
Copy link
Author

bleonard commented Sep 3, 2015

fwiw so far

var makeQuery = function(queryHash) {
  var keys = Object.getOwnPropertyNames(queryHash);
  if (Object.getOwnPropertySymbols) {
    keys = keys.concat(Object.getOwnPropertySymbols(queryHash));
  }

  var out = "";
  for (var i=0; i<keys.length; i++) {
    var key = keys[i];
    if (i > 0) out += " AND ";
    out += key + " = ";
    if ((typeof queryHash[key]) === 'number') {
      out += queryHash[key];
    }
    else {
      // TODO: how to escape? so far only ascii ids, so it's ok
      out += "'" + queryHash[key] + "'";
    }
  }
  if (out.length === 0) return null;
  return out;
};

@bleonard
Copy link
Author

bleonard commented Sep 3, 2015

what does a null query like realm.object('TodoItem', null) do?

@alazier
Copy link
Contributor

alazier commented Sep 4, 2015

realm.objects('TodoItem') gets all TodoItems. If you pass null for the query we will throw an exception as currently the second argument must be a string. If you want a query that will return all results you can use realm.objects("TodoItem", "truepredicate") and add build your string up from there.

@bleonard
Copy link
Author

bleonard commented Sep 4, 2015

ok, i'll return "truepredicate" instead of null

@bleonard bleonard closed this as completed Sep 4, 2015
alazier added a commit that referenced this issue Sep 28, 2015
Merge objectstore changes from obj-c
alazier added a commit that referenced this issue Nov 14, 2015
7701ba1 Merge pull request #16 from realm/tg-close
883ef12 Add Realm::close() and call it in RealmCache::clear()
e9ca54e Merge pull request #12 from realm/tg-core-0.94.4
0823a62 Merge pull request #13 from realm/tg-is-empty
62f59d9 Merge pull request #15 from realm/tg-file-error-path
b93e5ce Include the path of the file which actually failed to open in exceptions
e1e9cd8 Add ObjectStore::is_empty()
52e7e61 Update for core 0.94.4
271432b Merge pull request #11 from realm/kd-rename-delegate-to-bindingcontext
db36ca5 Remove Realm suffix
70e1967 Rename realm delegate in transact_log_handler as well
4973827 Rename RealmDelegate to RealmBindingContext
347145b Merge pull request #8 from realm/mar-migrate-required-to-optional
0b45772 Add a test showing our behavior when migrating from an optional column to a required column.
9f1702a Support migrating required columns to optional, preserving their contents.
f5b790c Merge pull request #6 from realm/tg-impl
6dfeaf8 Move things which are not part of the API to an impl directory/namespace
513e483 Merge pull request #4 from realm/tg-realm
f646777 Send changes_available() even if autorefresh is enabled
21d32bf Add a bit of documentation for RealmDelegate
95c80c9 Fix error in cleanup after an error during a migration
b7936bb Simplify column shifting for removed properties a little
a0f1dab Add a Schema class, move lookup by name and internal-consistency checks there
b381437 Make Realm::compact() more robust
6133eeb Reduce the scope of a variable
0c111a2 Fix a comment
ba278c5 Fix checks for what types of columns can be optional
7de20ea USe more const refs to avoid copies
dbac77f Make a bunch of things const
1400450 Remove an unused function
06e0ff8 Share ExternalCommitHelpers between Realm instances for a single path
f79dec9 Allow more nullable property types when supported
0eb0bd1 Honor is_nullable when creating columns
ea5c475 Refactor schema initialization a bit
e4f29fe Move the interprocess notification functionality to the object store
b129ebe Shuffle stuff around and clean some things up
eeb2ddd Improve array KVO performance a bit
c3649fb Skip PK uniqueness checking when first creating a Realm file
0a41c85 Improve performance of realm_requires_update() and make more things const
efdfa08 Port some of the KVO support functionality to the object store
65e1eb5 Add the ability to bypass the Realm cache entirely
3f226cf Rework change notifications
045c7b2 Add Realm::get_schema_version()
e4377bb Change realm::Schema to a vector rather than a map
cae4cf2 Remove property.hpp include from object_schema.hpp
55e6cca Convert RLMRealmConfiguration to a wrapper around Realm::Config
563a837 Use NSDMIs for realm::Property
0ae1bb1 Don't cache dynamic realms in the ObjectStore cache either
25a6734 Eliminate some copies
45890f2 Use NSDMIs for Realm
348f4a7 Reduce s_init_mutex's scope
b4f856b Use NSDMIs for Realm::Config and make it moveable
a91839b Store a copy of the encryption key
0700428 Merge pull request #3 from realm/al-bugfixes
b084335 clear Realm cache between tests
cb8364c property copy schema from cached realms
8712c8b fixes for latest object store changes
453e4d8 Fix crash when adding a property to a model without updating the schema version.

git-subtree-dir: src/object-store
git-subtree-split: 7701ba1
@tomduncalf tomduncalf mentioned this issue Jan 19, 2022
12 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants