Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@realm/react] Bundle in lodash.isequal #6458

Open
kraenhansen opened this issue Feb 2, 2024 · 2 comments · Fixed by #6633
Open

[@realm/react] Bundle in lodash.isequal #6458

kraenhansen opened this issue Feb 2, 2024 · 2 comments · Fixed by #6633
Assignees
@Ydixit007
Labels
First-Good-Issue First Good Issue - Relatively easy issue for new contributers @realm/react T-Internal

Comments

@kraenhansen
Copy link
Member

kraenhansen commented Feb 2, 2024 •
edited by sync-by-unito bot

Since we're only using isEqual from lodash we should avoid requiring in the entire library as it'll be difficult for end-users to shake off. Instead we could depend on the more limited lodash.isequal package and optionally avoid excluding it to pull it into our bundle.
@kraenhansen kraenhansen changed the title [@realm/react] Bundle in `lodash.isequal [@realm/react] Bundle in lodash.isequal Feb 2, 2024
@sync-by-unito sync-by-unito bot added the First-Good-Issue First Good Issue - Relatively easy issue for new contributers label Feb 5, 2024
@Ydixit007
Copy link
Contributor

Hi kraenhansen,

Your suggestion to optimize the code by importing only the lodash.isequal package is a great idea. I'll can handle this issue.
Could you please assign this issue to me? I'll make sure to get it sorted out.

@kneth
Copy link
Member

kneth commented Feb 9, 2024

@Ydixit007 We welcome PRs, and we will look forward to your contribution.

@Ydixit007 Ydixit007 mentioned this issue Apr 21, 2024
Merged
@sync-by-unito sync-by-unito bot reopened this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ydixit007 Ydixit007

Labels
First-Good-Issue First Good Issue - Relatively easy issue for new contributers @realm/react T-Internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RJS-2717: Replaced lodash with lodash.isequal Ydixit007/realm-js
3 participants
@kneth @kraenhansen @Ydixit007