Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RJS-2717: Replaced lodash with lodash.isequal #6633

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Ydixit007
Copy link

What, How & Why?

Since we're only using isEqual from lodash we should avoid requiring in the entire library as it'll be difficult for end-users to shake off. Instead we could depend on the more limited lodash.isequal package.

This closes #6458 .

Copy link

cla-bot bot commented Apr 21, 2024

Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @Ydixit007. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a @cla-bot check comment. The GitHub usernames you file there will need to match that of your Pull Requests. If you have any questions or cannot file the CLA electronically, make a comment here and we will be happy to help you out.

@Ydixit007
Copy link
Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Apr 21, 2024
Copy link

cla-bot bot commented Apr 21, 2024

The cla-bot has been summoned, and re-checked this pull request!

@kraenhansen kraenhansen changed the title Replaced lodash with lodash.isequal RJS-2717: Replaced lodash with lodash.isequal Apr 24, 2024
@kraenhansen
Copy link
Member

npm ERR! Missing: @types/lodash.isequal@4.5.8 from lock file
npm ERR! Missing: lodash.isequal@4.5.0 from lock file

You'll need to run npm install and commit the changes to the lock file 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@realm/react] Bundle in lodash.isequal
2 participants