Node 10 support #2092
Merged
Node 10 support #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealebenpae
approved these changes
Nov 5, 2018
fealebenpae
reviewed
Nov 6, 2018
fealebenpae
reviewed
Nov 6, 2018
| @@ -18,7 +18,7 @@ RUN touch /var/lib/rpm/* \ | |||
| && yum -y install \ | |||
| python27 \ | |||
| which \ | |||
| chrpath \ | |||
| chrpath \:q | |||
There was a problem hiding this comment.
This looks like a vim artefact
cmelchior
reviewed
Nov 6, 2018
CHANGELOG.md
Outdated
| @@ -2,6 +2,7 @@ x.x.x Release notes (yyyy-MM-dd) | |||
| ============================================================= | |||
| ### Enhancements | |||
| * A more meaningful exception will be thrown when trying to refresh the access token for a Realm with an invalid url. Previously, trying to connect to a Realm with a url that lacks the path component (e.g. `realm://foo.com`) would result in errors like `Cannot read property ‘token_data’ of undefined`. Instead, now we'll print out the Realm url and provide a more meaningful exception message. ([#ROS-1310](https://github.com/realm/realm-object-server-private/issues/1310), since v1.0.2) | |||
| * Adds support for Node 10. Pre-gyp'ed binaries are avaiable for Node 6, 8, and 10. ([#1813](https://github.com/realm/realm-js/issues/1813) and [#2087](https://github.com/realm/realm-js/issues/2087)) | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Adding support for node 10, and removing node 7 and 9 support (odd-numbered versions of node are development versions).
This closes #1813
☑️ ToDos
Compatibilitylabel is updated or copied from previous entry[ ] 🚦 Tests[ ] 📝 Public documentation PR created or is not necessary[ ] 💥Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's:
[ ] typescript definitions file is updated[ ] jsdoc files updated[ ] Chrome debug API is updated if API is available on React Native