Add support for uploading. and downloading changes easily #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealebenpae
reviewed
Nov 20, 2018
Co-Authored-By: cmelchior <christian@ilios.dk>
nirinchev
reviewed
Nov 20, 2018
nirinchev
reviewed
Nov 20, 2018
Co-Authored-By: cmelchior <christian@ilios.dk>
Co-Authored-By: cmelchior <christian@ilios.dk>
|
Ready for review |
kneth
approved these changes
Nov 21, 2018
src/js_sync.hpp
Outdated
| Function<T>::callback(protected_ctx, protected_callback, typename T::Object(), 1, callback_arguments); | ||
| }); | ||
|
|
||
| completion_func = std::move(completion_handler); |
There was a problem hiding this comment.
The pattern was copied from add_progress_notification, but not sure it is strictly needed
nirinchev
approved these changes
Nov 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2122
This PR adds two new API's:
These match the methods found in Realm Java.
TODO: