Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating CHANGELOG.md #2201

Merged
merged 3 commits into from Jan 9, 2019
Merged

Updating CHANGELOG.md #2201

merged 3 commits into from Jan 9, 2019

Conversation

kneth
Copy link
Member

@kneth kneth commented Jan 8, 2019

No description provided.

@kneth kneth self-assigned this Jan 8, 2019
CHANGELOG.md Outdated
@@ -6,6 +6,7 @@ x.x.x Release notes (yyyy-MM-dd)
### Fixed
* Fixed building on Android. ([#2189](https://github.com/realm/realm-js/issues/2189), since v2.22.0-beta.2)
* Fix an occasional crash due to an uncaught `realm::IncorrectThreadException` when a client reset error occurs. ([#2193]()https://github.com/realm/realm-js/pull/2193)
* Fix a bug in the sync worker to use correct default values. Thanks to @radovanstevanovic. ([#2195](https://github.com/realm/realm-js/pull/2195), since v2.2.2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear for me what the end user would see before this fix?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we set the value (see https://github.com/realm/realm-js-private/blob/f22b064b7f20047d4cf33b01ee4070a69a308b69/spec/notifier_tests.ts#L721) when we use Realm.Worker. We haven't seen any reports, and it is unlikely that any user has used it directly.

@kneth kneth merged commit f1584c2 into master Jan 9, 2019
@kneth kneth deleted the kneth/update-changelog branch January 9, 2019 07:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants