Update versions of all the things used in tests #2242

tgoyne · 2019-01-30T18:54:05Z

You can no longer build modules for node 6 on macOS 10.14, so we need to upgrade to a newer version. Unsurprisingly this then has cascading effects where everything else needs to be upgraded too.

An overview of the things changed here:

Node 8 and npm 6 are now used for running all the test scripts. install-local is used to mimick the pre-npm5 behavior when installing modules from filepaths where needed (i.e. where symlinking in the realm module breaks things).
React Native is upgraded to 0.58. This requires switching to use CocoaPods for building the native modules on iOS, which also removes the need for some of our hacks. The react native iOS tests now actually work (7e8b7d7 broke the test app and it's been crashing when running on CI for months without reporting a failure).
Updated Android stuff to work with newer versions of gradle. There's still some deprecation warnings that indicate it'll break again with gradle 6.
Upgraded eslint to 5.0 and fixed a pile of warnings and errors from the new recommended setting.
Bumped the electron version used for tests to 4.0 and fixed some unrelated pre-existing issues with running the tests in electron.
Fixed some assorted minor issues when building with Xcode 10 and bumped the last-upgrade-check versions.
Update to the newest versions of core/sync/ROS. The react-native tests were hitting an assertion failure in sync fixed in 3.15.0.
Chrome debugger/RPC server tests are now actually run (with recent versions of Xcode the Chrome_ tests failed to set the executor at the right time), and a pile of broken things in that are fixed.

jgreen01su · 2019-02-14T18:23:53Z

Is there anything I can do to help? I need iOS support for RN 0.58.x.

nonewcode · 2019-02-15T10:53:33Z

Any status update on this PR?

kerryaustin · 2019-02-20T04:09:03Z

Any update on this PR? Any way I can help?

bmunkholm · 2019-02-20T09:39:44Z

Left is just to review.

examples/ReactExample/package.json

react-native/ios/RealmReact/RealmReact.mm

react-native/package.json

cmelchior · 2019-02-20T09:31:52Z

scripts/download-realm.js

-                response.body.pipe(file).once('finish', () => file.close(resolve));
-            }).then(() => fs.utimes(destination, lastModified, lastModified));
-        }
+        }).catch(() => saveFile(response));


Why are we saving the file in case of an error?

This will hide the error, is that on purpose? I would console.error it at the least.

fs.stat() throws if the file does not exist or if the user doesn't have permission to access it. The former case isn't an error and we just want to download the file, and in the latter case saveFile will throw an error anyway.

tests/js/realm-tests.js

kraenhansen · 2019-02-20T12:03:05Z

examples/ReactExample/package.json

-    "babel-jest": "18.0.0",
-    "babel-preset-react-native": "4.0.0",
+    "eslint": "^3.0.0",
+    "install-local": "^0.6.2",


Looks like 1.0.0 shipped 8 days ago.

As this is an example I feel it's a little misleading to install Realm JS using this package. People might be looking at it as a reference on how to install Realm JS and get confused. The integration test I just merged had the same issue and I solved it by packing Realm JS and installing it from the package install script like so: https://github.com/realm/realm-js/blob/master/integration-tests/environments/react-native/package.json#L10 .. I don't know if that will be less confusing - but I wanted to mention an alternative.

Manually acquiring a tarball and calling npm install on that is significantly more dissimilar to how end users should install realm than this is. The point of using install-local is that it makes it almost identical to a normal dependency other than that it's in a separate section in package.json.

There is also a case to be made that this will actually not be using the .tgz that will eventually ship to users and instead it will package its own. Installing from the .tgz will catch more errors from potential issues with the way we might choose to package the archive.

install-local just calls npm pack and installs from that.

The reason we’ve had issues with regressions not being caught by tests in the past isn’t due to minor details around how realm is installed in tests: it’s because the node release is built from realm-js-private with a different build system and some important code differences, and while rjp has stuff set up to run the public tests against that module, it’s been broken for years. Assembling a tarball from this repo and installing from that isn’t any closer to testing the thing that users will actually install than anything else these tests have been doing.

Building from the package that we've already build at this point might speed up installing this app. I don't have a strong opinion here, thus it's not a blocker from my perspective - just wanted to share my thoughts.

scripts/test.sh

lib/user-methods.js

kneth

Great work - much appreciated!

I need to go through it once more.

kneth · 2019-02-20T14:55:01Z

Jenkinsfile

+
+def packageNpmArchive() {
+  return {
+    node('docker') {


Adding && !aws has been a help in the past.

I don't think that will do much, we have just a single node with that label https://ci.realm.io/label/aws/

It looks like some aws nodes are spawned from time to time (probably part of our cloud infrastructure).

yeah, Jenkins autoscales a set of slaves using spot instances.

scripts/download-realm.js

getContext() is not visible in extensions.js so _createUserAgentDescription() would always just throw an exception and report RealmJS/Unknown.

HarikaSabbella · 2019-02-23T06:50:28Z

@kneth when can we expect these changes to be released to NPM?

bmunkholm · 2019-02-23T09:02:02Z

@HarikaSabbella When we are done with the review - can't really give a date sorry, but likely sometime next week hopefully. Please have patience so we get the quality right. The beauty of open source is that if you can't wait, you can grab what is here if that works for you ;-)

munsifhayat · 2019-02-26T08:24:35Z

@bmunkholm Waiting passionately.

kraenhansen

Great work! 🎉

CHANGELOG.md

Co-Authored-By: tgoyne <tgoyne@gmail.com>

diegolmello · 2019-02-26T19:58:32Z

Nice! Is this going to be released today? 😆

nonewcode · 2019-02-26T20:31:06Z

Brilliant!

On Tue, 26 Feb 2019 at 19:58, Diego Mello ***@***.***> wrote: Nice! Is this going to be released today? 😆 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2242 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE3pnAQ55uL1HxnGy-UMH92GLRibOzQCks5vRZHtgaJpZM4aa1yj> .

-- Joshua Kelly *Director* *CodeCog Pty Ltd* m: 0408803053 w: codecog.com.au e: josh@codecog.com.au

kneth · 2019-02-27T14:33:55Z

@diegolmello I am not sure if we can make it today. If not, we'll get it out tomorrow.

kneth · 2019-02-27T15:28:22Z

@diegolmello I did have some time to get it released 😄

diegolmello · 2019-02-27T17:30:25Z

@kneth Hahahahaha. Great work, man. I'll try it later today. Thanks! 👊👊👊

tgoyne added the T-Internal label Jan 30, 2019

tgoyne self-assigned this Jan 30, 2019

realm-ci force-pushed the tg/npm-5 branch from 9b2a123 to 6c208ad Compare January 30, 2019 19:24

cmelchior mentioned this pull request Feb 1, 2019

Can't get Realm to work on iOS for React Native 0.58.0 #2239

Closed

realm-ci force-pushed the tg/npm-5 branch 2 times, most recently from 5dc39bb to 9748268 Compare February 8, 2019 18:41

tgoyne force-pushed the tg/npm-5 branch 4 times, most recently from ecb17f4 to 2214e2e Compare February 12, 2019 00:57

tgoyne force-pushed the tg/npm-5 branch 3 times, most recently from 189d049 to 1943428 Compare February 16, 2019 00:02

bmunkholm requested review from kneth, nirinchev, cmelchior and kraenhansen and removed request for nirinchev February 20, 2019 06:56

cmelchior reviewed Feb 20, 2019

View reviewed changes

kraenhansen reviewed Feb 20, 2019

View reviewed changes

scripts/test.sh Show resolved Hide resolved

kraenhansen reviewed Feb 20, 2019

View reviewed changes

scripts/test.sh Show resolved Hide resolved

kraenhansen reviewed Feb 20, 2019

View reviewed changes

scripts/test.sh Show resolved Hide resolved

kraenhansen reviewed Feb 20, 2019

View reviewed changes

lib/user-methods.js Show resolved Hide resolved

This was referenced Feb 20, 2019

Implement _asyncOpen as a RPC call for the RN debugger #2234

Closed

React Native - Debug JS Remotely #2199

Closed

tgoyne added 8 commits February 20, 2019 09:45

Fix a race condition in test setup

3d3f894

Only run Chrome tests when RCT_DEV is defined

5aef3dd

Test with both node 8 and node 10 on CI

e852e1c

Improve the PR job concurrency

d9c6578

Update the react-native example to 0.58

616807b

Remove some old debug code

c3a9f79

Update install-local to 1.0.0

0d25db5

Only modify the default nvm alias when running in Jenkins

729b0d6

tgoyne force-pushed the tg/npm-5 branch from 87affd5 to 729b0d6 Compare February 20, 2019 17:45

tgoyne added 2 commits February 20, 2019 10:41

Only try to shut down simulators on macos

ac60e61

Use Docker images with the correct version of node for the tests

248a9ae

tgoyne force-pushed the tg/npm-5 branch from 8bd6492 to 248a9ae Compare February 20, 2019 18:52

kneth reviewed Feb 20, 2019

View reviewed changes

tgoyne added 3 commits February 21, 2019 09:57

Explicitly use parseInt

d772c7c

Fix a ReferenceError in _createUserAgentDescription()

0d85430

getContext() is not visible in extensions.js so _createUserAgentDescription() would always just throw an exception and report RealmJS/Unknown.

Don't run the package job on aws nodes

b2f605e

kraenhansen approved these changes Feb 26, 2019

View reviewed changes

kneth approved these changes Feb 26, 2019

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

Improve changelog

0c31fd6

Co-Authored-By: tgoyne <tgoyne@gmail.com>

tgoyne merged commit 003f8b3 into master Feb 26, 2019

tgoyne deleted the tg/npm-5 branch February 26, 2019 19:36

github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update versions of all the things used in tests #2242

Update versions of all the things used in tests #2242

tgoyne commented Jan 30, 2019 •

edited

jgreen01su commented Feb 14, 2019

nonewcode commented Feb 15, 2019

kerryaustin commented Feb 20, 2019

bmunkholm commented Feb 20, 2019

cmelchior Feb 20, 2019

kraenhansen Feb 20, 2019

tgoyne Feb 20, 2019

kraenhansen Feb 20, 2019 •

edited

tgoyne Feb 20, 2019

kraenhansen Feb 21, 2019

tgoyne Feb 21, 2019

tgoyne Feb 21, 2019

kraenhansen Feb 22, 2019

kneth left a comment

kneth Feb 20, 2019

kraenhansen Feb 21, 2019

kneth Feb 22, 2019

alebsack Feb 22, 2019

HarikaSabbella commented Feb 23, 2019

bmunkholm commented Feb 23, 2019

munsifhayat commented Feb 26, 2019

kraenhansen left a comment

diegolmello commented Feb 26, 2019

nonewcode commented Feb 26, 2019 via email

kneth commented Feb 27, 2019

kneth commented Feb 27, 2019

diegolmello commented Feb 27, 2019

Update versions of all the things used in tests #2242

Update versions of all the things used in tests #2242

Conversation

tgoyne commented Jan 30, 2019 • edited

jgreen01su commented Feb 14, 2019

nonewcode commented Feb 15, 2019

kerryaustin commented Feb 20, 2019

bmunkholm commented Feb 20, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kraenhansen Feb 20, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kneth left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HarikaSabbella commented Feb 23, 2019

bmunkholm commented Feb 23, 2019

munsifhayat commented Feb 26, 2019

kraenhansen left a comment

Choose a reason for hiding this comment

diegolmello commented Feb 26, 2019

nonewcode commented Feb 26, 2019 via email

kneth commented Feb 27, 2019

kneth commented Feb 27, 2019

diegolmello commented Feb 27, 2019

tgoyne commented Jan 30, 2019 •

edited

kraenhansen Feb 20, 2019 •

edited