Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v10: Fix create performance in RN on iOS #3136

Merged
merged 1 commit into from
Aug 17, 2020
Merged

v10: Fix create performance in RN on iOS #3136

merged 1 commit into from
Aug 17, 2020

Conversation

blagoev
Copy link
Contributor

@blagoev blagoev commented Aug 14, 2020 •
edited

fix object create performance regression in RN on iOS
Fixes #2845

@blagoev blagoev requested a review from kneth August 14, 2020 15:17
@blagoev blagoev changed the title Fix create performance in RN on iOS v10: Fix create performance in RN on iOS Aug 14, 2020
kneth
kneth approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So simple, and yet so powerful 😄

@blagoev
Copy link
Contributor Author

blagoev commented Aug 17, 2020

Yes, as it turned out in order for the JSC to return a set JSValueRef exception on a JSxxx call it needs to capture the stack trace which is time consuming operation on iOS apparently. We don't need the exception in this case since we are walking up the prototype chain until no parent.

@blagoev blagoev merged commit 45b1281 into v10 Aug 17, 2020
@blagoev blagoev deleted the fix-create-performance-RN branch August 17, 2020 07:32
@RealmBot RealmBot mentioned this pull request Aug 17, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kneth kneth kneth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blagoev @kneth