-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RealmType -> Realm.Type #35
Conversation
retest this please |
1 similar comment
retest this please |
Looks good. I would personally prefer |
I'm also don't feel strongly about different naming schemes but think we should go with the most idiomatic option. Can you think of other libraries that might use other language or formatting? If not I'm happy to copy what React does. |
Nothing else solid is coming to mind. I think we should go lowercase for consistency with React, but also |
Other than that. 👍 |
It looks like the consensus online is to use capitalized names for constants and enums: Will go with that for now but can change later if we want. |
Add headers and core's CPP flags to cmake
First step towards proper namespacing
@appden