Support Hermes #3792

RedBeard0531 · 2021-06-07T14:10:02Z

What, How & Why?

🚧 WARNING 🚧

This is still a WIP, and there are still several TODOs and XXXs that will need to be addressed. Many parts of the implementation and integration are a bit hacky at the moment in order to get to a testable implementation that we can iterate on as quickly as possible.

Closes #2455

☑️ ToDos

port existing abstraction layer over to JSI/hermes
iOS support
Android support
Benchmark load time to prioritize lazy TurboModules vs eager NativeModule implementation
Revisit all TODOs and XXXs
Figure out how to support existing JSC implementation (and remote debugger) and Hermes side-by. (Or decide that it isn't practical and we will need a hard cut-over)
Figure out how we want to depend on hermes and where to get jsi.h from (this affects RN version compatability, since JSI doesn't seem to have a stable ABI)

📝 Changelog entry
📝 Compatibility label is updated or copied from previous entry
🚦 Tests
📝 Public documentation PR created or is not necessary
💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

typescript definitions file is updated
jsdoc files updated
Chrome debug API is updated if API is available on React Native

RedBeard0531 · 2021-06-07T14:13:01Z

src/hermes/jsi/jsi.h

+  /// Moves a Symbol, String, or Object rvalue into a new JS value.
+#if 0
+  template <typename T>
+#else // XXX Realm modification
+  template <typename T, typename = std::enable_if_t<
+            !std::is_reference_v<T> && 
+            (std::is_base_of<Symbol, T>::value ||
+             std::is_base_of<String, T>::value ||
+             std::is_base_of<Object, T>::value)
+          >>
+#endif
+  /* implicit */ Value(T&& other) : Value(kindOf(other)) {
+    static_assert(
+        std::is_base_of<Symbol, T>::value ||
+            std::is_base_of<String, T>::value ||
+            std::is_base_of<Object, T>::value,
+        "Value cannot be implicitly move-constructed from this type");


For now I've modified this to move the error out of the function to overload resolution. This results in much better error messages when I screw up. Before considering this "done" I'll want to either replace this file with a clean copy from upstream, or ideal set up the build so that we just use theirs without our own copy. But for now, it is nice having this modification in place.

Also, I plan to open a PR to do this upstream, so maybe we can have the best of both worlds.

FYI: facebook/hermes#526

HSReact · 2021-06-25T08:06:36Z

How’s it going guys? Can’t tell you how excited the community is for this feature…may the force be with you all 🙏🙏

sintylapse · 2021-06-28T15:02:07Z

Sorry for off topic, but the main thread is locked, and I think it is important for people to have backup plan, if they decide to migrate out of Realm to another DB and save their users data #3819 .

ghost · 2021-07-02T15:10:00Z

We are also following this thread closely. Any news?

RedBeard0531 · 2021-07-02T15:31:10Z

We have it working on iOS, but have been running into issues on android. There is some indication that our android issues may be fixed by facebook/react-native@24f9f75 (since the old version of libfbjni seems to break parts of the C++ stdlib), but it is only in the 0.65 RCs and not in a released version yet.

prscX · 2021-07-09T11:07:13Z

Thank you @RedBeard0531 for sharing the update. I'm curious to know, is it possible to have two separate releases, one for iOS and another for Android? Considering we have achieved support for iOS, maybe we can push a release for iOS now and later for Android. It will allow us to migrate our iOS apps to Hermes.

Thanks
</ Pranav >

HCSharma · 2021-07-14T09:38:33Z

Thank you @RedBeard0531 for sharing the update. I'm curious to know, is it possible to have two separate releases, one for iOS and another for Android? Considering we have achieved support for iOS, maybe we can push a release for iOS now and later for Android. It will allow us to migrate our iOS apps to Hermes.

Thanks
</ Pranav >

That is actually a great idea

HCSharma · 2021-07-14T09:44:02Z

@RedBeard0531 Its obvious but would like you to clarify, the version of realm that you are adding hermes support to, is the mongodb-realm version? Many folks have migrated to mongodb-realm after we were told Oct 2021 is end of support for traditional realm.

agape-apps · 2021-07-27T10:52:02Z

... have been running into issues on android. There is some indication that our android issues may be fixed by facebook/react-native@24f9f75 (since the old version of libfbjni seems to break parts of the C++ stdlib), but it is only in the 0.65 RCs and not in a released version yet.

The availability of 0.65.0 RC3 means that 0.65.0 is getting closer to be released. Is Hermes support for Android already available for testing with RN 0.65.0 RC3?

leecommamichael · 2021-08-05T21:05:43Z

It's kind of hard to believe that every React-Native app which uses Realm cannot currently produce a nice performance profile using Hermes. Profiling React-Native without Hermes is a mess.

prscX · 2021-08-12T06:57:26Z

Thank you @RedBeard0531 for sharing the update. I'm curious to know, is it possible to have two separate releases, one for iOS and another for Android? Considering we have achieved support for iOS, maybe we can push a release for iOS now and later for Android. It will allow us to migrate our iOS apps to Hermes.

Thanks
</ Pranav >

Would be very helpful if you can plan a separate Hermes support release for iOS and Android. It will allow us to port our iOS apps first. Please let us know your thoughts on the same.

Thanks,
</ Pranav >

marcosrdz · 2021-08-18T04:42:21Z

https://reactnative.dev/blog/2021/08/17/version-065

Fixed RN build issues on `build` step on Jenkins.

Since they're incompatible with RC 0.66.0.

… support Hermes (#4079) Rework the namespace names in our Hermes/JSI layer to more accurately reflect that we support JSI, and to remove ambiguities and namespace clashes. This closes RJS-1337.

kraenhansen · 2021-11-24T15:54:15Z

Closing this PR (and its branch) as we've now released two alpha releases and a third is expected any day.

We will be releasing from this hermes branch going forward.

kraenhansen · 2021-11-29T13:10:43Z

We've released a new version of Realm JS with support for the Hermes engine: Realm JS v10.20.0-alpha.2.
This fix the crash when reloading the app on Android.

Please take it for a spin and provide any feedback or issues you might have using the Hermes issue template:

npm install realm@hermes

RedBeard0531 requested a review from kraenhansen June 7, 2021 14:10

RedBeard0531 commented Jun 7, 2021

View reviewed changes

kraenhansen assigned RedBeard0531 Jun 8, 2021

Base automatically changed from ms/hermes-prep to master June 8, 2021 08:41

RedBeard0531 marked this pull request as draft June 10, 2021 08:23

RedBeard0531 changed the title ~~initial port of abstraction layer to hermes~~ Support Hermes Jun 10, 2021

ianpward mentioned this pull request Jun 11, 2021

Support Hermes engine #2455

Closed

norbertschuler mentioned this pull request Jun 11, 2021

[Snyk] Upgrade realm from 10.2.0 to 10.3.0 Plant-for-the-Planet-org/treemapper#314

Closed

Frans-L mentioned this pull request Jun 23, 2021

JSI support #3815

Closed

kneth mentioned this pull request Jun 24, 2021

Duplicate Symbols when trying to compile with a library that correctly references GCDWebServer in its podspec file #3814

Open

kneth mentioned this pull request Jul 1, 2021

[Discussion] Migrate out of Realm #3819

Closed

kneth mentioned this pull request Jul 7, 2021

RJSInitializeInContext EXC_BAD_ACCESS on launch #3831

Closed

takameyer mentioned this pull request Jul 19, 2021

Adding realm with "yarn add realm" causes react native app to crash without error message #3858

Closed

takameyer mentioned this pull request Aug 3, 2021

ObjectID Inconsistency on read #3622

Closed

kneth mentioned this pull request Aug 9, 2021

App doesn't start after Realm installation, error: com.facebook.react.JavaScript (12): EXC_BAD_ACCESS IOS #3888

Closed

kneth mentioned this pull request Aug 13, 2021

Crash When running on Android #3904

Closed

kraenhansen force-pushed the ms/hermes branch from e41992a to 11f8cba Compare August 17, 2021 08:55

kneth force-pushed the ms/hermes branch from 2a5ef7d to c214dae Compare September 2, 2021 07:34

kneth mentioned this pull request Sep 2, 2021

Feedback on Hermes support #3940

Closed

kraenhansen and others added 23 commits November 22, 2021 11:38

Adding an API to register invalidators

2c59d3b

Changed to angle bracket include

156ea1d

[10.20.0-alpha.0] PRE-RELEASE - DO NOT USE IN PRODUCTION

f4c117a

Fixed index accession on the empty string

38ef60f

Initial changes for Hermes on Android

b34233a

WIP

4240d48

WIP

be9140e

Updated the jsi.h

b4ff843

WIP

e7096c2

Adding "hermes/jsc" engine to integration test title

c0f7d84

Simplifying Android build scripts

9be2d13

Cherry-picked changes from #16a187e

2c646a6

[10.20.0-alpha.1] Bump version

84402f2

Insure caches are invalidated fixing reload crash

13b9e1c

Adding a note to the changelog

e0d1304

Upgraded ReactTestApp to React Native 0.66.0-rc.3

073b856

Ff/hermes ci build (#3980)

c03e050

Fixed RN build issues on `build` step on Jenkins.

Upgraded iOS apps to React Native 0.66.0-rc.3

03a2e25

Removed listview tests.

d7e2a1f

Since they're incompatible with RC 0.66.0.

Minor cleanups

07bca88

Removed an unused method

1f944c8

Reverted changes to build RN from source

fdbfadd

Fixed issue introduced during rebase

86188a2

kraenhansen force-pushed the ms/hermes branch from 611d440 to 86188a2 Compare November 22, 2021 10:39

Rename namespaces in the JSI codebase to reflect that it doesn't just…

aaabb8e

… support Hermes (#4079) Rework the namespace names in our Hermes/JSI layer to more accurately reflect that we support JSI, and to remove ambiguities and namespace clashes. This closes RJS-1337.

kraenhansen closed this Nov 24, 2021

kraenhansen deleted the ms/hermes branch November 24, 2021 15:54

github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Hermes #3792

Support Hermes #3792

RedBeard0531 commented Jun 7, 2021 •

edited by kraenhansen

Loading

RedBeard0531 Jun 7, 2021

RedBeard0531 Jun 7, 2021

HSReact commented Jun 25, 2021

sintylapse commented Jun 28, 2021

ghost commented Jul 2, 2021

RedBeard0531 commented Jul 2, 2021

prscX commented Jul 9, 2021 •

edited

Loading

HCSharma commented Jul 14, 2021

HCSharma commented Jul 14, 2021

agape-apps commented Jul 27, 2021

leecommamichael commented Aug 5, 2021

prscX commented Aug 12, 2021 •

edited

Loading

marcosrdz commented Aug 18, 2021

kraenhansen commented Nov 24, 2021

kraenhansen commented Nov 29, 2021

Support Hermes #3792

Support Hermes #3792

Conversation

RedBeard0531 commented Jun 7, 2021 • edited by kraenhansen Loading

What, How & Why?

☑️ ToDos

RedBeard0531 Jun 7, 2021

Choose a reason for hiding this comment

RedBeard0531 Jun 7, 2021

Choose a reason for hiding this comment

HSReact commented Jun 25, 2021

sintylapse commented Jun 28, 2021

ghost commented Jul 2, 2021

RedBeard0531 commented Jul 2, 2021

prscX commented Jul 9, 2021 • edited Loading

HCSharma commented Jul 14, 2021

HCSharma commented Jul 14, 2021

agape-apps commented Jul 27, 2021

leecommamichael commented Aug 5, 2021

prscX commented Aug 12, 2021 • edited Loading

marcosrdz commented Aug 18, 2021

kraenhansen commented Nov 24, 2021

kraenhansen commented Nov 29, 2021

RedBeard0531 commented Jun 7, 2021 •

edited by kraenhansen

Loading

prscX commented Jul 9, 2021 •

edited

Loading

prscX commented Aug 12, 2021 •

edited

Loading