Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logo in darkmode #4284

Merged
merged 2 commits into from Feb 3, 2022
Merged

Fix logo in darkmode #4284

merged 2 commits into from Feb 3, 2022

Conversation

takameyer
Copy link
Contributor

What, How & Why?

This closes # ???

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@cla-bot cla-bot bot added the cla: yes label Jan 31, 2022
@takameyer takameyer force-pushed the takameyer/readme-darkmode-fix branch 9 times, most recently from 0c1fce0 to fd515ed Compare January 31, 2022 12:17
@tomduncalf
Copy link
Contributor

LGTM

@kraenhansen
Copy link
Member

kraenhansen commented Jan 31, 2022

So the logos will be vertically stacked on https://www.npmjs.com/package/realm? (which is currently broken in dark-mode btw).

@takameyer
Copy link
Contributor Author

takameyer commented Jan 31, 2022

@kraenhansen That's true! So basically they implemented a non-standard method of doing this that breaks everywhere but here :D
Strange it's not working on npmjs. That should be detecting dark-mode correctly in the inline svg css. Maybe have to swap the default value there.

@kraenhansen
Copy link
Member

kraenhansen commented Jan 31, 2022

There's always the possibility of packing for NPM with an altered README.md, but that feels a bit involved for the problem at hand.

Copy link
Member

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nirinchev
Copy link
Member

There's always the possibility of packing for NPM with an altered README.md, but that feels a bit involved for the problem at hand.

As with everything in npm, apparently there's a package for that 😄 And it even has a github action you can plug before npm publish.

@takameyer takameyer force-pushed the takameyer/readme-darkmode-fix branch from fd515ed to 5c3b581 Compare February 1, 2022 14:19
@takameyer takameyer force-pushed the takameyer/readme-darkmode-fix branch from 5c3b581 to 3f7338a Compare February 1, 2022 14:21
@takameyer takameyer force-pushed the takameyer/readme-darkmode-fix branch from 692202b to 50c0d47 Compare February 1, 2022 15:03
@takameyer
Copy link
Contributor Author

@nirinchev I added a bash script to do the same. We can use it later when we have automated releases

@takameyer takameyer merged commit a236ab6 into master Feb 3, 2022
@takameyer takameyer deleted the takameyer/readme-darkmode-fix branch February 3, 2022 07:41
takameyer added a commit that referenced this pull request Feb 9, 2022
* Fix logo in darkmode

* Add a script to modify the readme to for publishing outside of github
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants