New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logo in darkmode #4284
Fix logo in darkmode #4284
Conversation
0c1fce0
to
fd515ed
Compare
LGTM |
So the logos will be vertically stacked on https://www.npmjs.com/package/realm? (which is currently broken in dark-mode btw). |
@kraenhansen That's true! So basically they implemented a non-standard method of doing this that breaks everywhere but here :D |
There's always the possibility of packing for NPM with an altered README.md, but that feels a bit involved for the problem at hand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As with everything in npm, apparently there's a package for that 😄 And it even has a github action you can plug before |
fd515ed
to
5c3b581
Compare
5c3b581
to
3f7338a
Compare
692202b
to
50c0d47
Compare
@nirinchev I added a bash script to do the same. We can use it later when we have automated releases |
* Fix logo in darkmode * Add a script to modify the readme to for publishing outside of github
What, How & Why?
This closes # ???
☑️ ToDos
Compatibility
label is updated or copied from previous entryBreaking
label has been applied or is not necessaryIf this PR adds or changes public API's: