-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@realm/react AppProvider and useApp #4470
Conversation
5b88c2e
to
0437c54
Compare
example/sync.config.js
Outdated
// Add your Realm App ID here if sync is enabled. | ||
appId: '<Your App ID>', | ||
appId: 'realmtemplate-waxdf', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everytime 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git update-index --assume-unchanged [ ...]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it is worth modifying this to use an environment variable (and then e.g. have a .env
file with your app id in which can be gitignore
d)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. It's probably best practice to inject your app id through an env var anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but just some small things
e7b1d96
to
9a47f72
Compare
Create a provider component that opens a Realm.App with a given configuration. Create a hook to access the app component. Update example to show useApp usage.
Co-authored-by: Tom Duncalf <tom.duncalf@mongodb.com>
2956fc3
to
1de886c
Compare
What, How & Why?
Create a provider component that opens a Realm.App with a given
configuration.
Create a hook to access the app component.
This closes #4456
☑️ ToDos
Compatibility
label is updated or copied from previous entryBreaking
label has been applied or is not necessaryIf this PR adds or changes public API's: