UserProvider and useUser #4557
Merged
UserProvider and useUser #4557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
reviewed
May 9, 2022
Comment on lines
94
to
97
| const combinedConfigWithUser = | ||
| user && !combinedConfig.sync?.user | ||
| ? mergeRealmConfiguration(combinedConfig, { sync: { user } }) | ||
| : combinedConfig; |
There was a problem hiding this comment.
Would this simplification be possible?
Suggested change
| const combinedConfigWithUser = | |
| user && !combinedConfig.sync?.user | |
| ? mergeRealmConfiguration(combinedConfig, { sync: { user } }) | |
| : combinedConfig; | |
| const combinedConfigWithUser = mergeRealmConfiguration({ sync: { user } }, combinedConfig); |
There was a problem hiding this comment.
With this suggestion, it is possible for a non-sync application to have {sync: {user: undefined}} included in the configuration. But maybe there is a way to simplify this.
There was a problem hiding this comment.
const combinedConfigWithUser =
combinedConfig?.sync && user ? mergeRealmConfiguration({ sync: { user } }, combinedConfig) : combinedConfig;
This is a little simpler.
There was a problem hiding this comment.
it is possible for a non-sync application to have {sync: {user: undefined}}
Yeah, I figured this could be an edge-case and wondered if mergeRealmConfiguration implemented a deletion of the sync property if all members has undefined values or something.
There was a problem hiding this comment.
That's perhaps another possibility
kraenhansen
reviewed
May 9, 2022
kraenhansen
approved these changes
May 10, 2022
takameyer
force-pushed
the
andrew/rr-use-user
branch
from
d1951b8
to
9187421
Compare
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Add UserProvider and useUser hook to allow access to the user within any place in the application.
Note: There are no tests, as this is unreasonable to test without actually spinning up a BAAS server. This is an unrealistic expectation for this work and should be done in a greater effort to refactor tests. I have, however, throughly tested this with the example application. If we do start getting bugs, we should find a way to create regression tests.
We will also need a follow up PR to update the Realm dependency as soon as the new release is out, as this is dependent on the new App and User listener events.
This closes #4456
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryBreakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: