Fix types and add a test for flexible sync client reset #4702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomduncalf
force-pushed
the
td/add-client-reset-flx-test
branch
from
0fd54df
to
366a7a2
Compare
tomduncalf
changed the title
tomduncalf
force-pushed
the
td/add-client-reset-flx-test
branch
from
366a7a2
to
c61cb14
Compare
kneth
approved these changes
Jul 4, 2022
11 tasks
|
Closing in favour of #4703 as CI was randomly failing on this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
I wanted to confirm this was working after a question from the docs team. It turns out our TS definition to only allow "manual" mode was a bit incorrect so I fixed it, and added a simple test which replicates the PBS one in the old tests
☑️ ToDos
Compatibilitylabel is updated or copied from previous entrypackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: