Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing use of protected_ctx causing crash when initialSubscriptions throws an error on Android #4710

Merged
merged 2 commits into from Jul 11, 2022

Conversation

tomduncalf
Copy link
Contributor

@tomduncalf tomduncalf commented Jul 8, 2022

What, How & Why?

This was working on iOS but crashing on Android, presumably the lifetime of the ctx is slightly different between the two platforms

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@cla-bot cla-bot bot added the cla: yes label Jul 8, 2022
@tomduncalf tomduncalf changed the title Fix missing use of protected_ctx causing crash on Android Fix missing use of protected_ctx causing crash when initialSubscriptions throws an error on Android Jul 8, 2022
@tomduncalf tomduncalf requested a review from takameyer July 8, 2022 10:38
Copy link
Contributor

@takameyer takameyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@tomduncalf tomduncalf merged commit 72799da into master Jul 11, 2022
@tomduncalf tomduncalf deleted the td/fix-android-flx-tests-2 branch July 11, 2022 10:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants