Andrew/fix dark mode #4780
Merged
Andrew/fix dark mode #4780
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takameyer
force-pushed
the
andrew/fix-dark-mode
branch
from
2c8172f
to
b27452f
Compare
kneth
approved these changes
Aug 16, 2022
|
@takameyer Should it target |
This uses an html version of the logo which supports dark mode. Githubs previous solution only worked on Github, but not on npmjs.com.
takameyer
force-pushed
the
andrew/fix-dark-mode
branch
from
b27452f
to
e5adafc
Compare
|
@kneth Removed that commit. Unsure how that got there 😂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Github now supports an html version of darkmode logos (https://github.blog/changelog/2022-08-15-specify-theme-context-for-images-in-markdown-ga/)
This updates our readme. It should fix the double logo on npmjs.com.
☑️ ToDos
Compatibilitylabel is updated or copied from previous entrypackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: