Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clang-format npm package version to match system clangd on newer Macs, and update code style to match #4869

Merged
merged 2 commits into from Sep 6, 2022

Conversation

tomduncalf
Copy link
Contributor

@tomduncalf tomduncalf commented Sep 5, 2022

What, How & Why?

The default clangd installed on newer Macs formats empty classes differently. As the system version is used by the VS Code plugin, but the version used for the lint job is fixed (it is packaged in the clang-format npm package), this results in lint errors if you rely on your editor to format the code on newer Macs.

Our config would seem to be setup such that these empty classes should in fact be split but perhaps some new option has been added that we haven't set. Given that it's not a huge deal, and also that the config structure is pretty complex so figuring it out could take a while, I thought the pragmatic solution was to update the clang-format package to match the newer clangd.

⚠️ This may require you to update your clangd version (e.g. via Homebrew and add it to your path) if you are on an older Mac.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@cla-bot cla-bot bot added the cla: yes label Sep 5, 2022
Copy link
Member

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the way you have formatted these empty classes.

Copy link
Contributor

@takameyer takameyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@tomduncalf tomduncalf merged commit e5fa96a into master Sep 6, 2022
@tomduncalf tomduncalf deleted the td/update-clang-format branch September 6, 2022 10:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants