Refactor useObject #5208
Merged
Refactor useObject #5208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prime any list properties with an cachedCollection so that updates fire correctly (Fixes #5185) * Primary Keys as non-primative values would reset the cached objects, since their reference always changes * Create a listener on the collection if the object doesn't exist, and rerender when it is created (Fixes #4514)
takameyer
force-pushed
the
andrew/realm-react/useObject
branch
from
ac6b264
to
b5d36a0
Compare
This was referenced Dec 31, 2022
elle-j
approved these changes
Jan 3, 2023
| const listCaches = new Map(); | ||
| const listTearDowns: Array<() => void> = []; | ||
| // If the object doesn't exist, just return it with an noop tearDown | ||
| if (object === null) { | ||
| return { object, tearDown: () => undefined }; | ||
| } | ||
|
|
||
| // Create a cache for any Realm.List properties on the object | ||
| object.keys().forEach((key) => { |
There was a problem hiding this comment.
Not sure how significant it would be in this particular case, but for of loops are usually a lot faster than forEach. So I assume in this case it would depend on how many times the function will be called and the number of keys on the object.
There was a problem hiding this comment.
I agree - I would opt for a for-of loop over the forEach here.
gagik
approved these changes
Jan 3, 2023
appden
reviewed
Jan 6, 2023
kraenhansen
reviewed
Jan 9, 2023
| const listCaches = new Map(); | ||
| const listTearDowns: Array<() => void> = []; | ||
| // If the object doesn't exist, just return it with an noop tearDown | ||
| if (object === null) { | ||
| return { object, tearDown: () => undefined }; | ||
| } | ||
|
|
||
| // Create a cache for any Realm.List properties on the object | ||
| object.keys().forEach((key) => { |
There was a problem hiding this comment.
I agree - I would opt for a for-of loop over the forEach here.
Co-authored-by: LJ <81748770+elle-j@users.noreply.github.com> Co-authored-by: Kræn Hansen <kraen.hansen@mongodb.com>
|
I've gotten all the PR changes. Unless someone yells, I'll get this merged sometime tomorrow. |
kraenhansen
reviewed
Jan 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This closes #5185 and #4514
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: