Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal migration tests - use same path for all tests #55

Merged
merged 4 commits into from
Oct 13, 2015
Merged

Conversation

alazier
Copy link
Contributor

@alazier alazier commented Oct 13, 2015

@appden

closes #44

@alazier alazier mentioned this pull request Oct 13, 2015

DeleteRealmFilesAtPath(RealmPathForFile(@"test.realm"));
DeleteRealmFilesAtPath(RealmPathForFile(@"test1.realm"));
DeleteRealmFilesAtPath(RealmPathForFile(@"test2.realm"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see where test.realm is created, but where does test1.realm and test2.realm come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are created in the js tests. We should really be doing a pattern match and delting all realm files in the docuements dir. Will add a TODO for this.

@appden
Copy link
Contributor

appden commented Oct 13, 2015

👍

alazier added a commit that referenced this pull request Oct 13, 2015
Minimal migration tests - use same path for all tests
@alazier alazier merged commit f4715da into master Oct 13, 2015
@alazier alazier deleted the al-migrations branch October 14, 2015 20:11
alazier added a commit that referenced this pull request Oct 26, 2015
Minimal migration tests - use same path for all tests
appden pushed a commit that referenced this pull request Apr 22, 2016
Add support for building with the various sanitizers
alazier pushed a commit that referenced this pull request Sep 14, 2016
…gument

SyncGlobalNotifier: Delay closing of Realm accessor
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support/Test Migrations
2 participants