Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node example app (Connection State Change and Error Handling) #6100

Merged
merged 27 commits into from Sep 1, 2023
Merged

Add Node example app (Connection State Change and Error Handling) #6100

merged 27 commits into from Sep 1, 2023

Conversation

elle-j
Copy link
Member

@elle-j elle-j commented Aug 25, 2023 •
edited

What, How & Why?

Adds the Node.js example for Connection State Change and Error Handling.

This is the same behavior as the original example, but updates the following:

  • From Realm v11 to v12.
  • From JavaScript to TypeScript.
  • From require to import.

For reviewers

Given that the code has been previously reviewed, you can pay more attention to the following:

  • The tsconfig.json file.
  • Setup of Realm model classes (in src/models).

☑️ ToDos

--

@elle-j elle-j requested review from takameyer and kneth August 25, 2023 12:05
@cla-bot cla-bot bot added the cla: yes label Aug 25, 2023
kneth
kneth approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating to v12.x.

examples/example-node-connection-and-error/src/realm-query.ts Outdated Show resolved Hide resolved
takameyer
takameyer approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@takameyer takameyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions and questions. LGTM!

examples/example-node-connection-and-error/src/atlas-app-services/getAtlasApp.ts Outdated Show resolved Hide resolved
examples/example-node-connection-and-error/src/atlas-app-services/getAtlasApp.ts Outdated Show resolved Hide resolved
examples/example-node-connection-and-error/src/realm-auth.ts Outdated Show resolved Hide resolved
examples/example-node-connection-and-error/src/realm-auth.ts Outdated Show resolved Hide resolved
examples/example-node-connection-and-error/src/realm-query.ts Outdated Show resolved Hide resolved
examples/example-node-connection-and-error/README.md Outdated Show resolved Hide resolved
examples/example-node-connection-and-error/src/realm-auth.ts Outdated Show resolved Hide resolved
@elle-j
Add Node.js example app using TS, ESM, and v12.
6d9a534
@elle-j
Update comments.
0c21f41
@elle-j
Convert models into classes.
324d65e
@elle-j
Add example node app to workspaces.
8ad5d5d
@elle-j
Update README.
83d88af
@elle-j
Remove license in package.json.
55be7dd
@elle-j
Update start script.
79af08c
@elle-j
Add .gitignore.
c3ea2ab
@elle-j
Remove unused options in tsconfig.
6a99bc7
@elle-j
Update comments.
bc1fcd5
@elle-j
Add copyright headers.
af9ea94
@elle-j
Update README.
75745b4
@elle-j
Add comment about already logged in user.
b5dbd3d
@elle-j
Remove 'npx' from package.json script.
e6955d0
@elle-j
Prefix package.json name with _at_realm.
11b15da
@elle-j
Refactor hardcoded constant to variable.
cfd424a
@elle-j
Add missing 'Realm' import (it used the global Realm).
16f286a
@elle-j
Show helpful error message if App ID is not set.
3cfa4e1
@elle-j
Widen the App ID constant to a 'string'.
dd02ea1
@elle-j
Change 'all' log level to 'error'.
7a2c3df
@elle-j
Reorganize comment.
f814486
@elle-j
Use full npm command in README.
761639a
@elle-j
Add manual trigger of connection listener.
cb9e780
@elle-j elle-j force-pushed the lj/example-node-error-handling branch from f7fa58e to 3ee749e Compare September 1, 2023 15:56
@elle-j elle-j merged commit 174e678 into main Sep 1, 2023
28 checks passed
@elle-j elle-j deleted the lj/example-node-error-handling branch September 1, 2023 16:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@takameyer takameyer takameyer approved these changes

@kraenhansen kraenhansen kraenhansen left review comments

@kneth kneth kneth approved these changes

Assignees

@elle-j elle-j

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elle-j @takameyer @kneth @kraenhansen