Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add updates to the addition of deleteUser in example app #6208

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Add updates to the addition of deleteUser in example app #6208

merged 3 commits into from
Oct 25, 2023

Conversation

elle-j
Copy link
Member

@elle-j elle-j commented Oct 20, 2023 •
edited
Loading

What, How & Why?

Makes a few updates to the addition of deleteUser to the example app:

  • Moves deleteUser responsibility to useDemoSyncTriggers.
  • Updates the README with the new use case.
  • Removes rollup related changes in package-lock.json.

☑️ ToDos

--

@elle-j elle-j requested a review from takameyer October 20, 2023 15:36
@coveralls-official
Copy link

Coverage Status

coverage: 85.397%. remained the same when pulling 94f8502 on lj/delete-user-additions into 5656140 on andrew/delete-user.

@elle-j elle-j mentioned this pull request Oct 20, 2023
Merged
7 tasks
elle-j
elle-j commented Oct 23, 2023
View reviewed changes
examples/rn-connection-and-error/frontend/app/hooks/useDemoSyncTriggers.ts
* Trigger the user event listener by removing the user from the app.
*/
const deleteUser = useCallback(() => {
// TODO: Update to use only `deleteUser`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this TODO until #5327 is fixed.

@takameyer takameyer merged commit 792328c into andrew/delete-user Oct 25, 2023
28 of 30 checks passed
@takameyer takameyer deleted the lj/delete-user-additions branch October 25, 2023 08:45
@elle-j elle-j mentioned this pull request Oct 30, 2023
Merged
takameyer pushed a commit that referenced this pull request Oct 31, 2023
@elle-j @takameyer
Add updates to the addition of deleteUser in example app (#6208)
6f07e03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@takameyer takameyer takameyer approved these changes

Assignees

@elle-j elle-j

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elle-j @takameyer