Suggested changes to kneth/realm-core-14.0.1
#6516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
commented
Feb 28, 2024
| @@ -146,7 +146,7 @@ export enum LogCategory { | |||
| /** | |||
| * Type for `Realm.setLogLevel` | |||
| */ | |||
| export type LogArgs = { | |||
| export type LogOptions = { | |||
There was a problem hiding this comment.
We tend to use "options" to describe the type of object passed as the sole argument to a function.
kraenhansen
commented
Feb 28, 2024
| /** | ||
| * Represents an entry in the log. | ||
| */ | ||
| export type LogEntry = { |
There was a problem hiding this comment.
I believe "entry" is semantically more precise.
kraenhansen
commented
Feb 28, 2024
Comment on lines
-179
to
-181
| * @param category - The category (origin) of the log entry. | ||
| * @param level - The level of the log entry. | ||
| * @param message - The message of the log entry. |
There was a problem hiding this comment.
As these are not separate arguments to the callback, I've moved these descriptions into the properties on the object's type above.
kneth
approved these changes
Feb 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Instead of a lot of suggested changes in the GitHub PR UI, I thought a PR would be better.