Followup to #6492, allowing "$$typeof" to be read from binding prior to injection #6524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efore it's injected. Using Object.assign instead of replacing the injected.
kneth
approved these changes
Mar 4, 2024
bimusiek
pushed a commit
to bimusiek/realm-js
that referenced
this pull request
Mar 14, 2024
…rior to injection (realm#6524) * Making path-browserify an actual dependency * Adding a list of ignored props that can be accessed on the binding, before it's injected. Using Object.assign instead of replacing the injected. * Applying patch before injecting * Adding a note to the changelog * Fixed the injection assertion
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This closes #6522 by adding a set of properties that can be accessed prior to injection.
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary