Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing changelog-header.sh with a TypeScript equivalent #6587

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Replacing changelog-header.sh with a TypeScript equivalent #6587

merged 3 commits into from
Apr 4, 2024

Conversation

kraenhansen
Copy link
Member

What, How & Why?

Running the bash script locally errored with:

❯ ./scripts/changelog-header.sh
./scripts/changelog-header.sh: line 6: unexpected EOF while looking for matching `)'

Instead of spending time debugging it, I rewrote it in TypeScript.

@kraenhansen kraenhansen added T-Internal no-changelog no-jira-ticket Skip checking the PR title for Jira reference labels Apr 4, 2024
@kraenhansen kraenhansen requested review from kneth and elle-j April 4, 2024 08:57
@kraenhansen kraenhansen self-assigned this Apr 4, 2024
@cla-bot cla-bot bot added the cla: yes label Apr 4, 2024
elle-j
elle-j approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good initiative 🙂

.github/workflows/publish-package-release.yml Outdated Show resolved Hide resolved
CHANGELOG.header.md Outdated Show resolved Hide resolved
@kraenhansen kraenhansen merged commit 86eb923 into main Apr 4, 2024
28 checks passed
@kraenhansen kraenhansen deleted the kh/prepend-changelog-script branch April 4, 2024 10:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elle-j elle-j elle-j approved these changes

@kneth kneth Awaiting requested review from kneth

Assignees

@kraenhansen kraenhansen

Labels
cla: yes no-changelog no-jira-ticket Skip checking the PR title for Jira reference T-Internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kraenhansen @elle-j