Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RJS-2789: Surface errors when linking credentials fails #6588

Merged
merged 9 commits into from
Apr 4, 2024

Conversation

kraenhansen
Copy link
Member

What, How & Why?

This closes #6586 by adding an additional check on the errorCode before initiating the refresh of the access token.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests (manually in a local Vite app)
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 💥 Breaking label has been applied or is not necessary

@kraenhansen kraenhansen self-assigned this Apr 4, 2024
@kraenhansen kraenhansen requested a review from elle-j April 4, 2024 09:08
@cla-bot cla-bot bot added the cla: yes label Apr 4, 2024
@kraenhansen kraenhansen requested a review from kneth April 4, 2024 09:08
@kraenhansen kraenhansen force-pushed the kh/surface-errors-when-linking branch from fa7cd1f to e4a2402 Compare April 4, 2024 10:18
@kraenhansen kraenhansen force-pushed the kh/surface-errors-when-linking branch from e4a2402 to e6c9193 Compare April 4, 2024 11:05
Copy link
Member

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/realm-web/package.json Outdated Show resolved Hide resolved
@kraenhansen kraenhansen merged commit 4e99e63 into main Apr 4, 2024
32 checks passed
@kraenhansen kraenhansen deleted the kh/surface-errors-when-linking branch April 4, 2024 12:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling User#linkCredentials with the email of a non-existing user or wrong password never surface error
2 participants