Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish with provenance statements #6602

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Conversation

kneth
Copy link
Member

@kneth kneth commented Apr 8, 2024

What, How & Why?

Following this guide as it seems to be simple 😄

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 💥 Breaking label has been applied or is not necessary

@cla-bot cla-bot bot added the cla: yes label Apr 8, 2024
@kneth kneth added no-jira-ticket Skip checking the PR title for Jira reference and removed cla: yes labels Apr 8, 2024
@kneth kneth requested a review from elle-j April 8, 2024 13:39
@kneth kneth requested a review from kraenhansen April 8, 2024 13:39
Copy link
Member

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adding a "repository" (and likely a nested "directory" as well) to babel-plugin/package.json (and possibly also to fetch/package.json, but unsure if it will actually be needed there if it's only used internally).

@cla-bot cla-bot bot added the cla: yes label Apr 9, 2024
@kneth kneth force-pushed the kneth/publish-with-provenance branch from 152f12b to e1e4062 Compare April 11, 2024 13:23
Copy link
Member

@kraenhansen kraenhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make sense to test an rc release from this branch, before merging it.

@kneth
Copy link
Member Author

kneth commented Apr 11, 2024

Testing it by releasing an rc (#6608)

@kneth kneth merged commit 5dab798 into main Apr 11, 2024
31 checks passed
@kneth kneth deleted the kneth/publish-with-provenance branch April 11, 2024 16:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants