Adding tests accessing app.currentUser from App and User listeners
#6649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
added
T-Test
no-changelog
no-jira-ticket
elle-j
reviewed
May 2, 2024
| @@ -235,6 +236,50 @@ describe("App", () => { | |||
| expect(this.app.currentUser).to.be.null; | |||
| }); | |||
|
|
|||
| it("currentUser is available from an App listener", async function (this: Mocha.Context & AppContext & RealmContext) { | |||
There was a problem hiding this comment.
Lint warning
Suggested change
| it("currentUser is available from an App listener", async function (this: Mocha.Context & AppContext & RealmContext) { | |
| it("currentUser is available from an App listener", async function (this: Mocha.Context & | |
| AppContext & | |
| RealmContext) { |
| await handle; | ||
| }); | ||
|
|
||
| it.only("currentUser is available from a User listener", async function (this: Mocha.Context & AppContext & RealmContext) { |
There was a problem hiding this comment.
Lint warning (and sweet ol' only 🙂)
Suggested change
| it.only("currentUser is available from a User listener", async function (this: Mocha.Context & AppContext & RealmContext) { | |
| it("currentUser is available from a User listener", async function (this: Mocha.Context & | |
| AppContext & | |
| RealmContext) { |
| it.only("currentUser is available from a User listener", async function (this: Mocha.Context & AppContext & RealmContext) { | ||
| expect(this.app.currentUser).to.be.null; | ||
|
|
||
| const credentials = Realm.Credentials.anonymous(false); |
There was a problem hiding this comment.
Will the false actually make a difference here? Or can it not be guaranteed that this is the only logged in user when this test is run? (The previous test used the default argument.)
kneth
reviewed
May 3, 2024
| const credentials = Realm.Credentials.anonymous(); | ||
|
|
||
| const handle = createPromiseHandle(); | ||
| const listener = () => { |
There was a problem hiding this comment.
Will this function be called once or twice? If twice, you will resolve the promise too early.
There was a problem hiding this comment.
I expect it to be called only once. It doesn't behave as collection and object listeners (where it fires initially).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This exercise realm/realm-core#7670 and realm/realm-core#7183 to ensure future regressions will be easier to debug.
We should hold back on merging this, until realm/realm-core#7670 is fixed and we've upgraded Core to include the fix.