Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RJS-2835: Include immediatelyRunFileActions in opt-in list #6709

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

kneth
Copy link
Member

@kneth kneth commented Jun 6, 2024

What, How & Why?

This closes #6708

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 💥 Breaking label has been applied or is not necessary

@cla-bot cla-bot bot added the cla: yes label Jun 6, 2024
@kneth kneth requested a review from kraenhansen June 6, 2024 16:27
@kneth kneth requested a review from ironage June 6, 2024 16:27
Copy link
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!
It would be ideal to have a test of the manual client reset code path somewhere to make sure that this doesn't happen again, but that's up to you and your team.

@kneth kneth merged commit ea96198 into main Jun 6, 2024
32 checks passed
@kneth kneth deleted the kneth/immediately_run_file_actions branch June 6, 2024 18:40
@kraenhansen
Copy link
Member

kraenhansen commented Jun 6, 2024

Fix looks fine to me :shipit: This however was preventable. We should revisit the current strategy of generating @deprecated declarations for entities outside of the opt-in list or perhaps ensure eslint treats use of deprecated methods as an error 🤔 I'll add the issue as a topic for discussion at the upcoming round-table 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to handle a manual client reset due to a missing function
3 participants