Test/fix setting all primitive types to null/undefined #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (JSValueIsNull(ctx, value)) { | ||
| throw std::invalid_argument("`null` is not a number."); | ||
| } | ||
|
|
There was a problem hiding this comment.
I think you should check JSValueIsUndefined too.
There was a problem hiding this comment.
JSValueToNumber throws for undefined so the extra check is unnecessary.
|
Can you rebase this after merging the other PR since it contains duplicate commits. |
|
CI looks borked. Looks good to merge! 👍 |
alazier
added a commit
that referenced
this pull request
Oct 22, 2015
Test/fix setting all primitive types to null/undefined
fealebenpae
pushed a commit
that referenced
this pull request
Aug 2, 2016
Enable more warnings (and fix them)
This was referenced Mar 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #79
@appden