Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Sync demo sample base on 0.8.2 #16

Merged
merged 9 commits into from Jan 26, 2022
Merged

Add a Sync demo sample base on 0.8.2 #16

merged 9 commits into from Jan 26, 2022

Conversation

nhachicha
Copy link
Collaborator

No description provided.

@cla-bot cla-bot bot added the cla: yes label Jan 24, 2022
@nhachicha nhachicha self-assigned this Jan 24, 2022
@nhachicha nhachicha mentioned this pull request Jan 24, 2022
Closed
rorbech
rorbech reviewed Jan 25, 2022
View reviewed changes
Copy link
Contributor

@rorbech rorbech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we agree on doing this in the MultiplatformDemo and/or remove that, so we don't have to maintain two almost identical sample apps?

@nhachicha
Copy link
Collaborator Author

@rorbech I'll remove/repurpose the current MultiplatformDemo on another PR

@nhachicha nhachicha merged commit a669425 into main Jan 26, 2022
@nhachicha nhachicha deleted the nh/sync_demo branch January 26, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rorbech rorbech rorbech approved these changes

@cmelchior cmelchior Awaiting requested review from cmelchior

@clementetb clementetb Awaiting requested review from clementetb

Assignees

@nhachicha nhachicha

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nhachicha @rorbech