Update to Core 13.2.0 #1157

cmelchior · 2022-12-01T11:02:39Z

Update to Realm Core 13.2.0

The changes to Sync Connection Parameters are defined here: https://docs.google.com/document/d/1jUeN71gzQoLoYxHUawzIQaDVD2xDLbtbWkmxjIMcN-U/edit

TODO

closeShouldFreeMemory is failing on macOS. Turns out to only happen when running this test individually.
Test for Schema in synced Realms. We should only expose what is defined by the user.
Can we add something like "userDefined" in our internal schema metadata. Unclear if we can calculate this somewhere clever.

# Conflicts: # Jenkinsfile # packages/cinterop/src/androidAndroidTest/kotlin/io/realm/kotlin/test/CinteropTest.kt # packages/cinterop/src/nativeDarwinTest/kotlin/io/realm/kotlin/test/CinteropTest.kt # packages/external/core

rorbech

Looks OK to me. There are some itchy things around the schema that needs to be replicated all over the realms, but I guess cleaning it up goes better together with the standalone DynamicRealm-API and/or rework of our internal reuse of interfaces, etc. to improve the internal Realm hierarchy implementation.

.../library-base/src/androidMain/kotlin/io/realm/kotlin/internal/platform/SystemUtilsAndroid.kt

rorbech · 2023-01-11T12:47:07Z

...compiler/src/main/kotlin/io/realm/kotlin/compiler/RealmModelSyntheticPropertiesGeneration.kt

@@ -519,7 +519,8 @@ class RealmModelSyntheticPropertiesGeneration(private val pluginContext: IrPlugi
                                        property.locationOf()
                                    )
                                }
-                                val isIndexed = backingField.hasAnnotation(INDEX_ANNOTATION)
+                                // See https://github.com/realm/realm-core/issues/6187


I guess we didn't align on whether RealmSchema should reflect the actual schema or whether there was an index in effect. If going with the latter then I guess it should just be fixed in core. If we wan't to mimic the return value until it is fixed in core then we shouldn't change the schema here but just pass isPrimaryKey || isIndexed to the ValuePropertyType constructor in https://github.com/realm/realm-kotlin/blob/main/packages/library-base/src/commonMain/kotlin/io/realm/kotlin/internal/schema/RealmPropertyImpl.kt#L47

Hmm, right now I'm adding it here, while waiting for the Core fix, but also because I'm a little afraid that Core might not do it correctly at all, so just hacking the return value would just seem to mask even more bugs? 🤔

After discussion, I'll remove this fix for now and revert the test. This is now a "known bug" and we will talk with Core about a resolution.

...ages/test-base/src/androidAndroidTest/kotlin/io/realm/kotlin/test/shared/RealmSchemaTests.kt

packages/library-base/src/nativeIos/kotlin/io/realm/kotlin/internal/platform/SystemUtils.kt

packages/library-base/src/nativeDarwin/kotlin/io/realm/kotlin/internal/platform/SystemUtils.kt

packages/library-base/src/nativeIos/kotlin/io/realm/kotlin/internal/platform/SystemUtils.kt

packages/library-base/src/nativeMacos/kotlin/io/realm/kotlin/internal/platform/SystemUtils.kt

rorbech · 2023-01-11T13:30:00Z

.../library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/internal/AppConfigurationImpl.kt

@@ -107,23 +105,34 @@ public class AppConfigurationImpl constructor(
    private fun initializeSyncClientConfig(): RealmSyncClientConfigurationPointer =
        RealmInterop.realm_sync_client_config_new()
            .also { syncClientConfig ->
-                // TODO use separate logger for sync or piggyback on config's?


I am not really sure that I get the full details of this ... but do we need to note this in the CHANGELOG?

rorbech

LGTM. Only a minor thing with the changelog. ... And of course when CI is green 😅

CHANGELOG.md

Verify that creating a copy of Flexible Sync Realms works.

4afbae6

cla-bot bot added the cla: yes label Dec 1, 2022

cmelchior added 27 commits December 1, 2022 13:39

Create SNAPSHOT build for testing

e73e259

Fix tests

55aeb79

Formatting

1bcfe35

Merge branch 'main' into cm/write-copy-to-flx

a2a3eb9

# Conflicts: # Jenkinsfile # packages/cinterop/src/androidAndroidTest/kotlin/io/realm/kotlin/test/CinteropTest.kt # packages/cinterop/src/nativeDarwinTest/kotlin/io/realm/kotlin/test/CinteropTest.kt # packages/external/core

Quick hack for restricting schema when copying objects.

b41c29d

Fix detekt

035c3ed

Improve checking for accessors when copying objects

b586cf3

Also refresh public Realm when downloading changes time out.

af5ffaf

Add support for timestamps in JVM logs

8831294

Format miliseconds correctly

25e7f14

Update to lastest core commit

921e978

Re-enable Jenkins checks

7423b32

Add preliminary new support

9d010d5

Fix Darwin RealmInterop. Disable cleaning repo on builds

0c1aa8a

Add test for reproducing issue

7f3b6f2

Disable failing test

46f9e4e

Fix import

8796b7d

Update to latest Core version

521aee9

Ignore failing test

e46d6aa

Disable test

265bcee

Ignore more tests

79f807c

Disable testing on CI again

10de931

Test schema fix in Core

4d454fa

Fix import

c161d0b

Fix or ignore tests

5c461d0

Wipe workspace

4baea01

Remove Java only class

f2cd8b2

cmelchior changed the title ~~Enable writing a copy of flexible sync Realms~~ Update to Core 13.2.0 Dec 22, 2022

cmelchior added 7 commits January 10, 2023 14:39

Remove test

7103dbc

Re-enable backlink tests

6539b60

Restrict visible schema to the user defined + cleanup

5bbbfb3

DynamicRealms need the full schema

0b75404

Cleanup

7fa2414

Merge branch 'main' into cm/write-copy-to-flx

0bff9a6

Update to latest core version

0702265

rorbech reviewed Jan 11, 2023

View reviewed changes

cmelchior added 11 commits January 11, 2023 15:14

No need to use lazy

2061fb7

Ignore memory test

7243d13

Fix failed tests crashing the test reporter on native.

75f90ca

Fix test

d9ef501

Split PlatformInfo test for iOS / macOS

323340b

Cleanup connection params on macos and ios

5d78ce4

Fix detekt

a8c95d6

Add changelog entry for logging

5b5dcab

Update BAAS dependencies

d305b77

Add missing file for Gradle 7.6

d827076

Merge branch 'main' into cm/write-copy-to-flx

357a94b

cmelchior marked this pull request as ready for review January 12, 2023 12:43

cmelchior requested review from edualonso and clementetb January 12, 2023 12:43

cmelchior added 3 commits January 12, 2023 13:45

Delete file with wrong casing

3b605a8

Revert schema change

a5360ab

Fix compiler test

c754426

rorbech approved these changes Jan 13, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Fix test and changelog

0bd860f

cmelchior merged commit 91ce89d into main Jan 13, 2023

cmelchior deleted the cm/write-copy-to-flx branch January 13, 2023 08:02

github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to Core 13.2.0 #1157

Update to Core 13.2.0 #1157

cmelchior commented Dec 1, 2022 •

edited

rorbech left a comment

rorbech Jan 11, 2023 •

edited

cmelchior Jan 12, 2023

cmelchior Jan 12, 2023

rorbech Jan 11, 2023

rorbech left a comment

Update to Core 13.2.0 #1157

Update to Core 13.2.0 #1157

Conversation

cmelchior commented Dec 1, 2022 • edited

rorbech left a comment

Choose a reason for hiding this comment

rorbech Jan 11, 2023 • edited

Choose a reason for hiding this comment

cmelchior Jan 12, 2023

Choose a reason for hiding this comment

cmelchior Jan 12, 2023

Choose a reason for hiding this comment

rorbech Jan 11, 2023

Choose a reason for hiding this comment

rorbech left a comment

Choose a reason for hiding this comment

cmelchior commented Dec 1, 2022 •

edited

rorbech Jan 11, 2023 •

edited