This repository has been archived by the owner on Nov 8, 2021. It is now read-only.
Add metadata support for Realm file path info #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Added `SyncFileActionMetadata` class, representing file metadata - Refactored some of the metadata support code - Added additional checks for validation
austinzheng
force-pushed
the
az/metadata
branch
from
e3ac548
to
040da84
Compare
|
It's not clear what form this feature is going to take, if it's going to be included at all. I'll close and/or update this PR when we have more clarity. |
|
Closing this, since we don't want the associated feature anymore and the object store has changed drastically, meaning we'd have to refactor this code heavily even if we wanted to use it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, tests needed
Intended for use with the 'fetch Realm' functionality. Supersedes https://github.com/realm/realm-object-store-private/pull/54
Changes:
SyncFileActionMetadataclass, representing file metadata