Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a User I want to be able to open a local synced file on my disk from ROS #392

Closed
bmunkholm opened this issue Nov 9, 2017 · 3 comments · Fixed by #860
Closed

As a User I want to be able to open a local synced file on my disk from ROS #392

bmunkholm opened this issue Nov 9, 2017 · 3 comments · Fixed by #860
Assignees

Comments

@bmunkholm
Copy link
Contributor

Currently I get:
image

if I try to open a synced file as a local file.

  1. I want to open a file from a ROS installation locally on my disk. At least during development or even under production where a ROS realm file can be shipped for inspection.
  2. The error message should be clearer.
  3. There is a popup with the same message, and then the window (above) as well. One would suffice.
@bigfish24
Copy link
Contributor

@nhachicha will look into what is needed from realm-js to do this once he has time.

@nhachicha
Copy link
Contributor

I'll add a PR to expose the option in Realm-JS https://github.com/realm/realm-js/blob/e81d8589aede3529701df6b70b50d9ee85aa205a/lib/index.d.ts#L86 so we can pass in a boolean to force open the Relam without adding a SyncConfiguration

interface Configuration {
...
        sync?: Realm.Sync.SyncConfiguration | boolean;
...
    }

// so we can use it as 

const realm = new Realm({
      path: realmPath,
      sync: true,
    });

nhachicha added a commit that referenced this issue Dec 5, 2017
kraenhansen pushed a commit that referenced this issue Dec 12, 2017
* Fixes #392 open a local sync Realm

* fix lint:ts error

* PR feedback

* add staged changes (lint)

* PR feedback

*  PR feedback
kraenhansen added a commit that referenced this issue Dec 19, 2017
* Prepare version v1.9.1

* Add Kotlin Export Functionality (#483)

* Prepare version v1.10.0

* Update RELEASING.md

* Copied out the change to the package-lock version (#517)

This was previously merged to channel/cloud by
#407

* Upgrading electron (#516)

* Fixing an issue with the prepare script

* Adding CSV importer  (#479)

* Menu and actions refactored (#524)

* Refactoring the actions

* Using a MenuGenerator to generate menus when focussing a window

* Renamed ImportSchemaFormat to ImportFormat and avoiding default export

* Sending the success when using the Main and Renderer transports (#525)

* Create synced realm (#475)

* feat (realms): Add create realm logic

* feat (realms): Add button for creating new realm

* feat (ros): Add realm create logic

* chore (package): Update realm to 2.0.7

* feat (realms): Normalize path before creating a new synced realm

* feat (ros): Create realms with proper url

* feat (RealmsTableContainer): Move create realm callback to ros.realms

* feat (ToggleClass): Add new component

* refactor (FloatingControls): Use FloatingControls component in users and realms

* refactor (Sidebar): Move component to shared and improve folder structure

* refactor (_variables): Move file into shared

* feat (Sidebar): Apply class properly

* feat (RealmLoadingComponent): loadRealm now accept schema property

* feat (RealmBrowserContainer): Add onAddModel function

* feat (Sidebar): Add styles to the add model button

* refactor (): Rename onAddModel to onAddSchema

* feat (RealmBrowserContainer): Add modal for asking for the schema name

* feat (SchemaModal): Add isSchemaNameAvailable

* feat (SchemaModal): Add isSchemaNameAvailable

* feat (SchemaModal): Avoid repeat names creating schemas

* Merge branch 'master' into ic/create-synced-realm

# Conflicts:
#	src/ui/realm-browser/RealmBrowserContainer.tsx
#	src/ui/server-administration/realms/RealmSidebar/RealmSidebar.tsx

* style (RealmLoadingComponent): Fix indent problems

* refactor (RealmBrowserContainer): Use a simple approach

* feat (Sidebar): Use font-awesome in add schema button

* refactor (ToggleClass): Remove component

* refactor (AddSchemaModal): Using View component for stateless part

* feat (ContentGrid): Add noContentRenderer

Fix no scroll problems when table has header but not content

* feat (): Add column basic functionality

* feat (RealmBrowserContainer): Fix TS error

* feat (realm-browser): onAddColumnClick is now optional (Fix TS errors)

* feat (realm-browser): Allow create new properties with type and optional

* feat (realm-browser): Allow create new properties with type not primitives or list

* feat (AddSchemaPropertyModal): Remove unused properties

* feat (realm-browser): Add addColumn only when focus has enableAddColumn

* feat (realm-browser): Move enableAddColumn to IClassFocus

* feat (realm-browser): Only check enableAddColumn when focus.kind is class

* feat (realm-browser): Fix errors in onAddSchemaProperty

* feat (realm-browser): Allow add new object when table has no content

* feat (realm-browser): Add column controlled by focus.addColumnEnabled

* style (Cell): Remove extra space

* Using classNames differently

* Using an optional params object instead of each field being optional

* Updating naming and sorting object properties

* Updated naming to match the UI

* Forgot a change from "schema" to "class"

* Renamed onSchemaSelected to onClassSelected

* Closing the realm when unmounting as well

* Closing the realm before changing its schema

* Fixed adding properties on local Realms

* Making the "no content div" bigger

* Reordering

* Closing the realm after creation + selecting the latest realm after creation

* Using Realm.open to ensure the newly created Realm has synced

* "realm" => "Realm"

* Await Realm creation before hiding the create dialog

* "realm" => "Realm"

* Prepare version v1.11.0

* feat (AddPropertyModal): Improve type options select

* feat (AddPropertyModal): Improve optional message when is a list

* Fix creating synced properties (#530)

* Moved closing a realm to its own method

* Only calling the local realm opener with the schemaVersion - not synced

* Fixes #392 open a local sync Realm (#498)

* Fixes #392 open a local sync Realm

* fix lint:ts error

* PR feedback

* add staged changes (lint)

* PR feedback

*  PR feedback

* Prepare version v1.11.1

* refactor (AddPropertyModal): Simplify generateTypeOptions

* csv import into open realm (#532)

* Update electron builder (#539)

* Upgraded the electron-builder package

* Adding a script that checks the auto-update files

* Showing public in the Realm permissions table (#538)

This fixes #489

* Update package.json

Multiple publish providers was causing issues.

* Prepare version v1.12.0

* feat (AddClassModal): Allow add PK

* Update Jenkinsfile.release

Needed to be ** for node_modules to be copied recursively

* Update Jenkinsfile.release

Moved the check:auto-update-files to the individual build environments

* Update README.md

* feat (AddPropertyModal): Update Optional text

* feat (AddClassModal): Remove default option

* feat (AddPropertyModal): Improve options types header texts

* feat (AddClassModal): Simplify PK form

* Refactoring the way props are delivered to window containers (#557)

* Manual write transactions (#441)

* Work in progress

* Changes to the cells and extracted the parser

* The parser should complain when property is not optional

* Exporting the display function

* Fixing up the isScrolling and isAutoSaveEnabled props

* Counting the number of unsaved changes

* "Cancel" => "Discard"

* Capturing a closing window user has unsaved changes

* Persisting the auto save state

* Implemented (ctrl||command) + S to save

* Moved transaction controls from sidebar to bottombar + preparing an editMode

* Color adjustments

* Cleaning up some types

* Making types optional

* Turned hasEditingDisabled into an edit mode

* Making cells highlightable

* Calling a parent handler when validation changes

* Calling the superclass implementation of when unmounting

* Adding edit mode and transaction controls to the menu

* Only change class if validation passes

This fixes #119

* Change highlight on cells only if validation passes

* Transforming dates to strings
kraenhansen added a commit that referenced this issue Dec 21, 2017
* Prepare version v1.9.1

* Add Kotlin Export Functionality (#483)

* Prepare version v1.10.0

* Update RELEASING.md

* Copied out the change to the package-lock version (#517)

This was previously merged to channel/cloud by
#407

* Upgrading electron (#516)

* Fixing an issue with the prepare script

* Adding CSV importer  (#479)

* Menu and actions refactored (#524)

* Refactoring the actions

* Using a MenuGenerator to generate menus when focussing a window

* Renamed ImportSchemaFormat to ImportFormat and avoiding default export

* Sending the success when using the Main and Renderer transports (#525)

* Create synced realm (#475)

* feat (realms): Add create realm logic

* feat (realms): Add button for creating new realm

* feat (ros): Add realm create logic

* chore (package): Update realm to 2.0.7

* feat (realms): Normalize path before creating a new synced realm

* feat (ros): Create realms with proper url

* feat (RealmsTableContainer): Move create realm callback to ros.realms

* feat (ToggleClass): Add new component

* refactor (FloatingControls): Use FloatingControls component in users and realms

* refactor (Sidebar): Move component to shared and improve folder structure

* refactor (_variables): Move file into shared

* feat (Sidebar): Apply class properly

* feat (RealmLoadingComponent): loadRealm now accept schema property

* feat (RealmBrowserContainer): Add onAddModel function

* feat (Sidebar): Add styles to the add model button

* refactor (): Rename onAddModel to onAddSchema

* feat (RealmBrowserContainer): Add modal for asking for the schema name

* feat (SchemaModal): Add isSchemaNameAvailable

* feat (SchemaModal): Add isSchemaNameAvailable

* feat (SchemaModal): Avoid repeat names creating schemas

* Merge branch 'master' into ic/create-synced-realm

# Conflicts:
#	src/ui/realm-browser/RealmBrowserContainer.tsx
#	src/ui/server-administration/realms/RealmSidebar/RealmSidebar.tsx

* style (RealmLoadingComponent): Fix indent problems

* refactor (RealmBrowserContainer): Use a simple approach

* feat (Sidebar): Use font-awesome in add schema button

* refactor (ToggleClass): Remove component

* refactor (AddSchemaModal): Using View component for stateless part

* feat (ContentGrid): Add noContentRenderer

Fix no scroll problems when table has header but not content

* feat (): Add column basic functionality

* feat (RealmBrowserContainer): Fix TS error

* feat (realm-browser): onAddColumnClick is now optional (Fix TS errors)

* feat (realm-browser): Allow create new properties with type and optional

* feat (realm-browser): Allow create new properties with type not primitives or list

* feat (AddSchemaPropertyModal): Remove unused properties

* feat (realm-browser): Add addColumn only when focus has enableAddColumn

* feat (realm-browser): Move enableAddColumn to IClassFocus

* feat (realm-browser): Only check enableAddColumn when focus.kind is class

* feat (realm-browser): Fix errors in onAddSchemaProperty

* feat (realm-browser): Allow add new object when table has no content

* feat (realm-browser): Add column controlled by focus.addColumnEnabled

* style (Cell): Remove extra space

* Using classNames differently

* Using an optional params object instead of each field being optional

* Updating naming and sorting object properties

* Updated naming to match the UI

* Forgot a change from "schema" to "class"

* Renamed onSchemaSelected to onClassSelected

* Closing the realm when unmounting as well

* Closing the realm before changing its schema

* Fixed adding properties on local Realms

* Making the "no content div" bigger

* Reordering

* Closing the realm after creation + selecting the latest realm after creation

* Using Realm.open to ensure the newly created Realm has synced

* "realm" => "Realm"

* Await Realm creation before hiding the create dialog

* "realm" => "Realm"

* Prepare version v1.11.0

* feat (AddPropertyModal): Improve type options select

* feat (AddPropertyModal): Improve optional message when is a list

* Fix creating synced properties (#530)

* Moved closing a realm to its own method

* Only calling the local realm opener with the schemaVersion - not synced

* Fixes #392 open a local sync Realm (#498)

* Fixes #392 open a local sync Realm

* fix lint:ts error

* PR feedback

* add staged changes (lint)

* PR feedback

*  PR feedback

* Prepare version v1.11.1

* refactor (AddPropertyModal): Simplify generateTypeOptions

* csv import into open realm (#532)

* Update electron builder (#539)

* Upgraded the electron-builder package

* Adding a script that checks the auto-update files

* Showing public in the Realm permissions table (#538)

This fixes #489

* Update package.json

Multiple publish providers was causing issues.

* Prepare version v1.12.0

* feat (AddClassModal): Allow add PK

* Update Jenkinsfile.release

Needed to be ** for node_modules to be copied recursively

* Update Jenkinsfile.release

Moved the check:auto-update-files to the individual build environments

* Update README.md

* feat (AddPropertyModal): Update Optional text

* feat (AddClassModal): Remove default option

* feat (AddPropertyModal): Improve options types header texts

* feat (AddClassModal): Simplify PK form

* Refactoring the way props are delivered to window containers (#557)

* Manual write transactions (#441)

* Work in progress

* Changes to the cells and extracted the parser

* The parser should complain when property is not optional

* Exporting the display function

* Fixing up the isScrolling and isAutoSaveEnabled props

* Counting the number of unsaved changes

* "Cancel" => "Discard"

* Capturing a closing window user has unsaved changes

* Persisting the auto save state

* Implemented (ctrl||command) + S to save

* Moved transaction controls from sidebar to bottombar + preparing an editMode

* Color adjustments

* Cleaning up some types

* Making types optional

* Turned hasEditingDisabled into an edit mode

* Making cells highlightable

* Calling a parent handler when validation changes

* Calling the superclass implementation of when unmounting

* Adding edit mode and transaction controls to the menu

* Only change class if validation passes

This fixes #119

* Change highlight on cells only if validation passes

* Transforming dates to strings

* Update GUIDELINES.md

* Don't remove the initial path, that would possibly delete an incorrect Realm (#570)

* Prepare version v1.12.1

* Prepare version v1.13.0

* Auto generate uuid when creating new objects (#561)

* feat (CreateObject): Auto generate uuid when creating new objects

* feat (create-object-dialog): Avoid hack casting property for generateInitialValue

* "End of input" silenced + reconnect button upon failures (#567)

* Extracted a Status component

* Refactored ILoadingProgress from boolean done to a status

* Adding a LoadingOverlay to the Log component

* Refactored out the admin realm to the ServerAdministrationContainer

This fixes #556

* Created a script to simulate an unreliable ROS

* Upgrading ROS

* Showing just one LoadingOverlay

* Making sass-lint fail on warnings

* Upgraded the TypeScript compiler and the Awesome-Typescript-Loader

* Only reporting type errors from the src folder

* Upgrading react-virtualized

* Fixing issues that got discovered when upgrading TypeScript

* Don't render the "no content" div

* Respecting message linebreaks

* Show loading dots if in progress or no progress and loading

* Added a retry button and a method transforming error messages

* Open context menu when clicking in content grid (#562)

* feat (realm-browser): Open context menu when clicking in content grid

* refactor (realm-browser): Improve logic for validate if should open the menu

* refactor (realm-browser): Improve logic for validate if should open the menu

* Merge branch 'master' into kh/updates-from-master
@kraenhansen
Copy link
Member

Reopening this issue as the error message that we were matching on seems to have changed with the latest version of Realm JS:

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants