Add building and signing for all architectures #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
reviewed
Jan 3, 2024
resources/latest-mac.yml
Outdated
Comment on lines
1
to
12
| version: VERSION | ||
| files: | ||
| - url: Realm Studio-VERSION-mac.zip | ||
| sha512: ZIP_SHA | ||
| size: ZIP_SIZE | ||
| blockMapSize: ZIP_BLOCKMAP_SIZE | ||
| - url: Realm Studio-VERSION.dmg | ||
| sha512: DMG_SHA | ||
| size: DMG_SIZE | ||
| path: Realm Studio-VERSION.zip | ||
| sha512: ZIP_SHA | ||
| RELEASE_DATE |
There was a problem hiding this comment.
Was this committed on purpose? If so, what is it used for?
There was a problem hiding this comment.
This is referenced in the commented block for creating auto-update files for mac in the scenario where electron builder can't be relied on to correctly write that out - not used right now, but I thought it's a good idea to keep that documented if it ever comes up.
There was a problem hiding this comment.
In that case, I'd prefer if this was put into a markdown file with an introduction 👍
There was a problem hiding this comment.
Probably best would be sticking it into the comment for that code block, with annotation where it needs to go if that is needed again?
kraenhansen
reviewed
Jan 3, 2024
kraenhansen
reviewed
Jan 3, 2024
kraenhansen
reviewed
Jan 3, 2024
kneth
approved these changes
Jan 5, 2024
bwachter
force-pushed
the
channel/major-14
branch
2 times, most recently
from
83b4d4e
to
c6414ff
Compare
bwachter
force-pushed
the
channel/major-14
branch
from
c6414ff
to
5583844
Compare
kraenhansen
approved these changes
Jan 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds building, signing and release uploading for all architectures, and prepares adding universal builds for macOS as well as ARM builds for Windows/Linux.
Missing is the slack notification, and the changelog generation - that is mostly copy/paste from other projects, but we probably need to discuss if we should stick that in this workflow as well, or do a separate workflow for that.