Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dmg style #443

Merged
merged 2 commits into from
Nov 23, 2017
Merged

Improve dmg style #443

merged 2 commits into from
Nov 23, 2017

Conversation

IvanCoronado
Copy link
Contributor

closes #295

@kraenhansen kraenhansen changed the title Ic/improve dmg style Improve dmg style Nov 22, 2017
kraenhansen
kraenhansen requested changes Nov 22, 2017
View reviewed changes
Copy link
Member

@kraenhansen kraenhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using a *.png instead of a *.tiff, thats much more common and supported by electron-builder.

@IvanCoronado
Copy link
Contributor Author

@kraenhansen I used *.tiff for supporting retina as they suggest here https://www.electron.build/configuration/dmg

Really the background.tiff has 2 images with different resolutions, I followed apple recommendations for this https://developer.apple.com/library/content/documentation/GraphicsAnimation/Conceptual/HighResolutionOSX/Optimizing/Optimizing.html#//apple_ref/doc/uid/TP40012302-CH7-SW13

@kraenhansen kraenhansen merged commit c85ea78 into master Nov 23, 2017
@kraenhansen kraenhansen deleted the ic/improve-dmg-style branch November 23, 2017 16:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kraenhansen kraenhansen kraenhansen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Users installing via .dmg on Mac wants a more-Realm experience
2 participants
@IvanCoronado @kraenhansen